Debug the generic session restore failure.

chrome/browser/sessions/session_backend.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sessions/session_backend.h"
 
 #include <limits>
 
+#include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/memory/scoped_vector.h"
 #include "base/metrics/histogram.h"
+#include "base/string_number_conversions.h"
 #include "base/threading/thread_restrictions.h"
+#include "base/utf_string_conversions.h"
+#include "chrome/browser/browser_process.h"
+#include "chrome/browser/prefs/pref_service.h"
+#include "chrome/browser/prefs/scoped_user_pref_update.h"
+#include "chrome/common/pref_names.h"
+#include "content/public/browser/browser_thread.h"
 #include "net/base/file_stream.h"
 #include "net/base/net_errors.h"
 
 using base::TimeTicks;
 
 // File version number.
 static const int32 kFileCurrentVersion = 1;
 
 // The signature at the beginning of the file = SSNS (Sessions).
 static const int32 kFileSignature = 0x53534E53;
@@ skipping 237 matching lines @@
 }
 
 void SessionBackend::DeleteLastSession() {
   Init();
   file_util::Delete(GetLastSessionPath(), false);
 }
 
 void SessionBackend::MoveCurrentSessionToLastSession() {
   Init();
   current_session_file_.reset(NULL);
-
   const FilePath current_session_path = GetCurrentSessionPath();
   const FilePath last_session_path = GetLastSessionPath();
+  if (type_ == BaseSessionService::SESSION_RESTORE) {
+    // TODO(marja): This is only for debugging session restore failures; remove
+    // when debugging is done.
+    content::BrowserThread::PostTask(
+        content::BrowserThread::UI, FROM_HERE,
+        base::Bind(&SessionBackend::WriteDebugData, this));
+  }
   if (file_util::PathExists(last_session_path))
     file_util::Delete(last_session_path, false);
   if (file_util::PathExists(current_session_path)) {
     int64 file_size;
     if (file_util::GetFileSize(current_session_path, &file_size)) {
       if (type_ == BaseSessionService::TAB_RESTORE) {
         UMA_HISTOGRAM_COUNTS("TabRestore.last_session_file_size",
                              static_cast<int>(file_size / 1024));
       } else {
         UMA_HISTOGRAM_COUNTS("SessionRestore.last_session_file_size",
@@ skipping 115 matching lines @@
 }
 
 FilePath SessionBackend::GetCurrentSessionPath() {
   FilePath path = path_to_dir_;
   if (type_ == BaseSessionService::TAB_RESTORE)
     path = path.AppendASCII(kCurrentTabSessionFileName);
   else
     path = path.AppendASCII(kCurrentSessionFileName);
   return path;
 }
+
+void SessionBackend::WriteDebugData() {
+  PrefService* prefs = g_browser_process->local_state();
+  if (!prefs)
+    return;
+  ListPrefUpdate update(prefs, prefs::kSessionRestoreFilesCycled);
+  ListValue* list = update.Get();
+  if (list->GetSize() > 10)

[sky, 2012/08/24 23:42:25]

nit: while
Alkso, does this delete the value too if you end up removing?

[marja, 2012/08/27 07:37:18]

Done. It deletes the value, the docs say: "If |out_value| is NULL, the removed
value will be deleted."

+    list->Remove(0, NULL);
+  char time_string[32];
+  time_t now = base::Time::Now().ToTimeT();
+  strftime(time_string, 32, "%d.%m.%Y %H:%M:%S", localtime(&now));

[sky, 2012/08/24 23:42:25]

I thought we had conversion routines some where, but maybe I'm wrong?

[marja, 2012/08/27 07:37:18]

I was also a bit surprised that there is nothing in base/time.h. If we have
something, it's not very discoverable... :/

+  list->Append(new StringValue(
+#if defined(OS_POSIX)
+      base::IntToString(getpid()) + " " +
+#endif
+      std::string(time_string) + " " +
+#if defined(OS_WIN)
+      WideToUTF8(path_to_dir_.BaseName().value()) + " " +
+      WideToUTF8(CommandLine::ForCurrentProcess()->GetCommandLineString())));
+#else
+      path_to_dir_.BaseName().value() + " " +
+      CommandLine::ForCurrentProcess()->GetCommandLineString()));
+#endif
+}