Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1085363003: Replace FX_NEW with new, remove tests from fpdftext (Closed)

Created:
5 years, 8 months ago by Tom Sepez
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -28 lines) Patch
M core/src/fpdftext/fpdf_text.cpp View 3 chunks +7 lines, -15 lines 0 comments Download
M core/src/fpdftext/fpdf_text_int.cpp View 2 chunks +6 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, they just keep on coming.
5 years, 8 months ago (2015-04-15 22:28:30 UTC) #2
Lei Zhang
lgtm
5 years, 8 months ago (2015-04-16 18:37:48 UTC) #3
Tom Sepez
5 years, 8 months ago (2015-04-16 21:29:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7f6b6677665588a27b9d14babc6358840454ce17 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698