Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1085283002: Makefile: introduce debugsymbols=on flag (Closed)

Created:
5 years, 8 months ago by Jakob Kummerow
Modified:
5 years, 8 months ago
Reviewers:
Jarin
CC:
v8-dev, Igor Sheludko
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Makefile: introduce debugsymbols=on flag R=jarin@chromium.org Committed: https://crrev.com/2064c3c9b2149a36d9c4bcf5db2c374e9280e555 Cr-Commit-Position: refs/heads/master@{#27852}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M Makefile View 1 chunk +4 lines, -0 lines 0 comments Download
M build/standalone.gypi View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Jakob Kummerow
By popular demand :-) PTAL. Happy to rename the flag if you have a better ...
5 years, 8 months ago (2015-04-15 12:35:06 UTC) #2
Jarin
lgtm
5 years, 8 months ago (2015-04-15 13:05:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085283002/1
5 years, 8 months ago (2015-04-15 13:15:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085283002/1
5 years, 8 months ago (2015-04-15 15:03:16 UTC) #8
Jakob Kummerow
Committed patchset #1 (id:1) manually as 2064c3c9b2149a36d9c4bcf5db2c374e9280e555 (presubmit successful).
5 years, 8 months ago (2015-04-15 15:20:39 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 15:20:41 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2064c3c9b2149a36d9c4bcf5db2c374e9280e555
Cr-Commit-Position: refs/heads/master@{#27852}

Powered by Google App Engine
This is Rietveld 408576698