Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1085233002: BlinkGCPlugin: Fix JSonWriter after Clang r234897 (Closed)

Created:
5 years, 8 months ago by hans
Modified:
5 years, 8 months ago
Reviewers:
zerny-chromium, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

BlinkGCPlugin: Fix JSonWriter after Clang r234897 CompilerInstance::createOutputFile started returning a raw_pwrite_ostream, which is a super-class of raw_fd_ostream. We don't really care about the flavour of raw_ostream in JSonWriter, so just use the base class. BUG=476343 NOTRY=true Committed: https://crrev.com/6569bdceb0a1bf6c2510a0b4032095e72581805e Cr-Commit-Position: refs/heads/master@{#325236}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/clang/blink_gc_plugin/JsonWriter.h View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
hans
Please take a look.
5 years, 8 months ago (2015-04-15 09:42:23 UTC) #2
Nico
On 2015/04/15 09:42:23, hans wrote: > Please take a look. Lgtm
5 years, 8 months ago (2015-04-15 13:20:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085233002/1
5 years, 8 months ago (2015-04-15 13:27:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 13:30:15 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 13:31:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6569bdceb0a1bf6c2510a0b4032095e72581805e
Cr-Commit-Position: refs/heads/master@{#325236}

Powered by Google App Engine
This is Rietveld 408576698