Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Issue 1085163002: Introduce EditingAlgorithm<Traversal> class (Closed)

Created:
5 years, 8 months ago by yosin_UTC9
Modified:
5 years, 8 months ago
Reviewers:
tkent
CC:
blink-reviews, hajimehoshi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce EditingAlgorithm<Traversal> class This patch introduces |EditingAlgorithm<Traversal>| template class to use same algorithm on both DOM tree and composed tree for avoiding code duplication. This patch is result of collaboration work with hajimehoshi@chromium.org for selection of web components. After this patch, we are going to implement another strategies for the composed tree. We've already prepared that at http://crrev.com/1009603011. BUG=275851 TEST=n/a; No behavior changes. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193766

Patch Set 1 #

Patch Set 2 : 2015-04-15T16:50:42 Rebase for Position.h updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -39 lines) Patch
M Source/core/editing/EditingStrategy.h View 1 1 chunk +13 lines, -4 lines 0 comments Download
M Source/core/editing/EditingStrategy.cpp View 2 chunks +43 lines, -15 lines 0 comments Download
M Source/core/editing/htmlediting.h View 1 2 chunks +1 line, -6 lines 0 comments Download
M Source/core/editing/htmlediting.cpp View 1 chunk +1 line, -14 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
yosin_UTC9
PTAL
5 years, 8 months ago (2015-04-15 06:19:18 UTC) #2
tkent
lgtm
5 years, 8 months ago (2015-04-15 06:33:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085163002/20001
5 years, 8 months ago (2015-04-15 07:52:47 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 09:30:27 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193766

Powered by Google App Engine
This is Rietveld 408576698