Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 1085153002: [x64] Use xorl to materialize smi zero. (Closed)

Created:
5 years, 8 months ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[x64] Use xorl to materialize smi zero. Before we always loaded smi zero via a movabs with a 64-bit immediate, which is pretty expensive compared to the xorl. R=jarin@chromium.org Committed: https://crrev.com/f236777bfe6e080ff1ead6baf847cc9b6bb4f9cb Cr-Commit-Position: refs/heads/master@{#27829} Committed: https://crrev.com/5382e68691e2d869125735a07a19cf04d7f06ab4 Cr-Commit-Position: refs/heads/master@{#32784}

Patch Set 1 #

Patch Set 2 : REBASE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M src/x64/macro-assembler-x64.cc View 1 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Benedikt Meurer
5 years, 8 months ago (2015-04-15 04:18:42 UTC) #1
Benedikt Meurer
Hey Jaro, This is a straight forward optimization. Please take a look. Thanks, Benedikt
5 years, 8 months ago (2015-04-15 04:19:25 UTC) #2
Jarin
lgtm
5 years, 8 months ago (2015-04-15 05:59:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085153002/1
5 years, 8 months ago (2015-04-15 06:10:57 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 06:13:53 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/f236777bfe6e080ff1ead6baf847cc9b6bb4f9cb Cr-Commit-Position: refs/heads/master@{#27829}
5 years, 8 months ago (2015-04-15 06:14:03 UTC) #7
Benedikt Meurer
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1059543004/ by bmeurer@chromium.org. ...
5 years, 8 months ago (2015-04-16 08:29:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085153002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1085153002/20001
5 years ago (2015-12-11 09:36:43 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-11 09:38:31 UTC) #14
commit-bot: I haz the power
5 years ago (2015-12-11 09:39:03 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5382e68691e2d869125735a07a19cf04d7f06ab4
Cr-Commit-Position: refs/heads/master@{#32784}

Powered by Google App Engine
This is Rietveld 408576698