Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1085133002: Fix playback rate calculations for WallClockTimeSource. (Closed)

Created:
5 years, 8 months ago by DaleCurtis
Modified:
5 years, 8 months ago
Reviewers:
xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix playback rate calculations for WallClockTimeSource. The switch to wall clock time used playback rate incorrectly when calculating the wall clock time. Instead of multiplying by the rate it should be divided. BUG=477165 TEST=new unittest Committed: https://crrev.com/3ec02d642465872d9ab7d7db600d0480a57b3cab Cr-Commit-Position: refs/heads/master@{#325294}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Naming. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M media/base/wall_clock_time_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/wall_clock_time_source_unittest.cc View 1 4 chunks +26 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
DaleCurtis
Whoops :O Forgot these tests earlier. :(
5 years, 8 months ago (2015-04-15 01:37:11 UTC) #2
xhwang
lgtm % nit https://codereview.chromium.org/1085133002/diff/1/media/base/wall_clock_time_source_unittest.cc File media/base/wall_clock_time_source_unittest.cc (right): https://codereview.chromium.org/1085133002/diff/1/media/base/wall_clock_time_source_unittest.cc#newcode32 media/base/wall_clock_time_source_unittest.cc:32: bool IsWallClockNowForMediaTimeInSeconds(int seconds) { This naming ...
5 years, 8 months ago (2015-04-15 04:22:57 UTC) #3
DaleCurtis
https://codereview.chromium.org/1085133002/diff/1/media/base/wall_clock_time_source_unittest.cc File media/base/wall_clock_time_source_unittest.cc (right): https://codereview.chromium.org/1085133002/diff/1/media/base/wall_clock_time_source_unittest.cc#newcode32 media/base/wall_clock_time_source_unittest.cc:32: bool IsWallClockNowForMediaTimeInSeconds(int seconds) { On 2015/04/15 04:22:57, xhwang wrote: ...
5 years, 8 months ago (2015-04-15 18:42:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085133002/20001
5 years, 8 months ago (2015-04-15 18:43:48 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-15 20:39:18 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 20:40:12 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3ec02d642465872d9ab7d7db600d0480a57b3cab
Cr-Commit-Position: refs/heads/master@{#325294}

Powered by Google App Engine
This is Rietveld 408576698