Adds missing calls to reset long_jump_base.

runtime/vm/parser.cc

Index: runtime/vm/parser.cc
===================================================================
--- runtime/vm/parser.cc	(revision 31413)
+++ runtime/vm/parser.cc	(working copy)
@@ -743,6 +743,7 @@
                                              *(param[i].default_value));
       const Object* metadata = param[i].metadata;
       if ((metadata != NULL) && (*metadata).IsError()) {
+        isolate->set_long_jump_base(base);
         return (*metadata).raw();  // Error evaluating the metadata.

[hausner, 2014/01/02 18:54:23]

Not your code, but (*p).xxx is normally written as p->xxx. Feel free to leave as
is.

[zra, 2014/01/02 19:14:02]

Done.

       }
       param_descriptor.SetAt(j + kParameterMetadataOffset,
@@ -864,6 +865,7 @@
     Parser parser(script, lib, token_pos);
     parser.set_current_class(cls);
     parser.set_parsing_metadata(true);
+    isolate->set_long_jump_base(base);

[hausner, 2014/01/02 18:54:23]

I think this should happen after the call to EvaluateMetadata(), so we catch
exceptions in that function. This way we'd never get into the false branch of
this if statement.

[zra, 2014/01/02 19:14:02]

Done.

     return parser.EvaluateMetadata();
   } else {
     Error& error = Error::Handle();