Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 108513015: Set up more pieces necessary to show the main Window for views_examples_exe. (Closed)

Created:
6 years, 12 months ago by tfarina
Modified:
6 years, 11 months ago
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Set up more pieces necessary to show the main Window for views_examples_exe. We need to initialize ResourceBundle otherwise we can't call views::CreateDesktopScreen(). We will also need a gfx::Screen, otherwise we won't have any surface to show any thing. BUG=119759, 139313, 141187 TEST=views_examples_exe runs and does not crash. R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243898

Patch Set 1 #

Patch Set 2 : use_aura #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M ui/views/examples/examples_main.cc View 1 2 1 chunk +24 lines, -1 line 0 comments Download
M ui/views/views.gyp View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tfarina
6 years, 12 months ago (2013-12-24 13:42:27 UTC) #1
Ben Goodger (Google)
lgtm
6 years, 11 months ago (2014-01-06 17:24:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/108513015/1
6 years, 11 months ago (2014-01-06 17:41:35 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos_clang&number=65398
6 years, 11 months ago (2014-01-06 19:10:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/108513015/340001
6 years, 11 months ago (2014-01-06 23:26:40 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos_clang&number=65513
6 years, 11 months ago (2014-01-07 10:43:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/108513015/340001
6 years, 11 months ago (2014-01-09 03:19:25 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_chromeos_clang for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos_clang&number=66035
6 years, 11 months ago (2014-01-09 05:28:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/108513015/630001
6 years, 11 months ago (2014-01-09 12:54:54 UTC) #9
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 14:34:01 UTC) #10
Message was sent while issue was closed.
Change committed as 243898

Powered by Google App Engine
This is Rietveld 408576698