Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Issue 108513014: Convert clang=1 to the GN build. (Closed)

Created:
7 years ago by brettw
Modified:
7 years ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Convert clang=1 to the GN build. This maps clang=1 in GYP to is_clang=true in GN. BUG= R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242181

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M build/config/BUILDCONFIG.gn View 1 1 chunk +3 lines, -1 line 0 comments Download
M build/gyp_chromium View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
7 years ago (2013-12-20 00:16:21 UTC) #1
scottmg
lgtm
7 years ago (2013-12-20 00:31:07 UTC) #2
brettw
7 years ago (2013-12-20 21:39:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r242181 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698