Issue 108513007: Factor out common StepRange construction code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 108513007: Factor out common StepRange construction code. (Closed)

Created:
7 years ago by sof

Modified:
7 years ago

Reviewers:
tkent, keishi, yosin_UTC9

CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Factor out common StepRange construction code. Provide an InputType helper method for creating a StepRange given the default values to use. Use it for all InputTypes that have a step range bar Range. R= BUG=257369 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163656

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -30 lines)			Patch
M	Source/core/html/forms/DateInputType.cpp	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	Source/core/html/forms/DateTimeLocalInputType.cpp	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	Source/core/html/forms/InputType.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/html/forms/InputType.cpp	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	Source/core/html/forms/MonthInputType.cpp	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	Source/core/html/forms/NumberInputType.cpp	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	Source/core/html/forms/TimeInputType.cpp	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	Source/core/html/forms/WeekInputType.cpp	View	1 chunk	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sof

Please take a look when you next have a moment to spare. Following up on ...

7 years ago (2013-12-10 17:28:40 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/108513007/1

7 years ago (2013-12-10 23:23:35 UTC) #3

Message was sent while issue was closed.

Change committed as 163656

Expand Messages | Collapse Messages