Add SkTileGridPicture SampleApp playback support.

Add SkTileGridPicture SampleApp playback support.

SampleApp already supports switching to a bbox hierarchy playback mode
('b' shortcut). This CL adds an SkTileGridPicture bbox mode.

R=reed@google.com,robertphillips@google.com

Committed: http://code.google.com/p/skia/source/detail?r=12613

[robertphillips, 2013-12-10 18:44:27]

lgtm + nits

https://codereview.chromium.org/108513006/diff/1/samplecode/SampleApp.cpp
File samplecode/SampleApp.cpp (right):

https://codereview.chromium.org/108513006/diff/1/samplecode/SampleApp.cpp#new...
samplecode/SampleApp.cpp:655: 
can these be const?

https://codereview.chromium.org/108513006/diff/1/samplecode/SampleApp.cpp#new...
samplecode/SampleApp.cpp:669: struct TilingInfo* info = gTilingInfo +
fTilingMode;
this->width/this->height

https://codereview.chromium.org/108513006/diff/1/samplecode/SampleApp.cpp#new...
samplecode/SampleApp.cpp:1206: } else {
this->tileSize

https://codereview.chromium.org/108513006/diff/1/samplecode/SampleApp.cpp#new...
samplecode/SampleApp.cpp:1747: if (SampleView::IsSampleView(curr_view(this))) {
this->tileSize

https://codereview.chromium.org/108513006/diff/1/samplecode/SampleApp.cpp#new...
samplecode/SampleApp.cpp:2111: sampleView->requestMenu(fSlideMenu);
this->tileSize

https://codereview.chromium.org/108513006/diff/1/samplecode/SampleApp.cpp#new...
samplecode/SampleApp.cpp:2267: if (fTilingMode != kNo_Tiling &&
SampleView::IsSampleView(view)) {
this->tileSize

https://codereview.chromium.org/108513006/diff/1/samplecode/SamplePictFile.cpp
File samplecode/SamplePictFile.cpp (right):

https://codereview.chromium.org/108513006/diff/1/samplecode/SamplePictFile.cp...
samplecode/SamplePictFile.cpp:50: 
override?

https://codereview.chromium.org/108513006/diff/1/samplecode/SamplePictFile.cp...
samplecode/SamplePictFile.cpp:53: fTileSize = tileSize;
SkSafeSetNull?

https://codereview.chromium.org/108513006/diff/1/samplecode/SamplePictFile.cp...
samplecode/SamplePictFile.cpp:60: // overrides from SkEventSink
override keyword?

https://codereview.chromium.org/108513006/diff/1/samplecode/SamplePictFile.cp...
samplecode/SamplePictFile.cpp:96: enum BBoxType {
kNo_BBoxType? same for others?

https://codereview.chromium.org/108513006/diff/1/samplecode/SamplePictFile.cp...
samplecode/SamplePictFile.cpp:100: 
kLast_BBoxType? (no _enum)?
Also shouldn't this be:

kLast_BBoxType = kTileGrid_BBoxType
};
static const BBoxType kBBoxTypeCount = kLast_BBoxType + 1;

https://codereview.chromium.org/108513006/diff/1/samplecode/SamplePictFile.cp...
samplecode/SamplePictFile.cpp:143: 
put const on the left hand side (e.g., kNo_BBox != bbox)?

https://codereview.chromium.org/108513006/diff/1/samplecode/SamplePictFile.cp...
samplecode/SamplePictFile.cpp:144: if (bbox != kNo_BBox) {
Doesn't the next 5 lines only need to be done if we are creating a tile grid?

[fmalita_google_do_not_use, 2013-12-10 19:48:17]

https://codereview.chromium.org/108513006/diff/1/samplecode/SampleApp.cpp
File samplecode/SampleApp.cpp (right):

https://codereview.chromium.org/108513006/diff/1/samplecode/SampleApp.cpp#new...
samplecode/SampleApp.cpp:655: 
On 2013/12/10 18:44:28, robertphillips wrote:
> can these be const?

Done.

https://codereview.chromium.org/108513006/diff/1/samplecode/SampleApp.cpp#new...
samplecode/SampleApp.cpp:669: struct TilingInfo* info = gTilingInfo +
fTilingMode;
On 2013/12/10 18:44:28, robertphillips wrote:
> this->width/this->height

Done.

https://codereview.chromium.org/108513006/diff/1/samplecode/SampleApp.cpp#new...
samplecode/SampleApp.cpp:1206: } else {
On 2013/12/10 18:44:28, robertphillips wrote:
> this->tileSize

Done.

https://codereview.chromium.org/108513006/diff/1/samplecode/SampleApp.cpp#new...
samplecode/SampleApp.cpp:1747: if (SampleView::IsSampleView(curr_view(this))) {
On 2013/12/10 18:44:28, robertphillips wrote:
> this->tileSize

Done.

https://codereview.chromium.org/108513006/diff/1/samplecode/SampleApp.cpp#new...
samplecode/SampleApp.cpp:2111: sampleView->requestMenu(fSlideMenu);
On 2013/12/10 18:44:28, robertphillips wrote:
> this->tileSize

Done.

https://codereview.chromium.org/108513006/diff/1/samplecode/SampleApp.cpp#new...
samplecode/SampleApp.cpp:2267: if (fTilingMode != kNo_Tiling &&
SampleView::IsSampleView(view)) {
On 2013/12/10 18:44:28, robertphillips wrote:
> this->tileSize

Done.

https://codereview.chromium.org/108513006/diff/1/samplecode/SamplePictFile.cpp
File samplecode/SamplePictFile.cpp (right):

https://codereview.chromium.org/108513006/diff/1/samplecode/SamplePictFile.cp...
samplecode/SamplePictFile.cpp:50: 
On 2013/12/10 18:44:28, robertphillips wrote:
> override?

Done.

https://codereview.chromium.org/108513006/diff/1/samplecode/SamplePictFile.cp...
samplecode/SamplePictFile.cpp:53: fTileSize = tileSize;
On 2013/12/10 18:44:28, robertphillips wrote:
> SkSafeSetNull?

Done.

https://codereview.chromium.org/108513006/diff/1/samplecode/SamplePictFile.cp...
samplecode/SamplePictFile.cpp:60: // overrides from SkEventSink
On 2013/12/10 18:44:28, robertphillips wrote:
> override keyword?

Done.

https://codereview.chromium.org/108513006/diff/1/samplecode/SamplePictFile.cp...
samplecode/SamplePictFile.cpp:96: enum BBoxType {
On 2013/12/10 18:44:28, robertphillips wrote:
> kNo_BBoxType? same for others?

Done.

https://codereview.chromium.org/108513006/diff/1/samplecode/SamplePictFile.cp...
samplecode/SamplePictFile.cpp:100: 
On 2013/12/10 18:44:28, robertphillips wrote:
> kLast_BBoxType? (no _enum)?
> Also shouldn't this be:
> 
> kLast_BBoxType = kTileGrid_BBoxType
> };
> static const BBoxType kBBoxTypeCount = kLast_BBoxType + 1;

Oh yeah, the style guide is quite specific about this. Done.

https://codereview.chromium.org/108513006/diff/1/samplecode/SamplePictFile.cp...
samplecode/SamplePictFile.cpp:143: 
On 2013/12/10 18:44:28, robertphillips wrote:
> put const on the left hand side (e.g., kNo_BBox != bbox)?

Done.

https://codereview.chromium.org/108513006/diff/1/samplecode/SamplePictFile.cp...
samplecode/SamplePictFile.cpp:144: if (bbox != kNo_BBox) {
On 2013/12/10 18:44:28, robertphillips wrote:
> Doesn't the next 5 lines only need to be done if we are creating a tile grid?

That is correct, I was trading sloppiness for brevity. There's probably a better
way to handle it... done.

[commit-bot: I haz the power, 2013-12-10 21:50:46]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/108513006/20001

[commit-bot: I haz the power, 2013-12-10 21:51:10]

Change committed as 12613