Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 1085123002: ozone: drm: Restore cursor in CrtcController::Modeset (Closed)

Created:
5 years, 8 months ago by spang
Modified:
5 years, 8 months ago
CC:
chromium-reviews, kalyank, piman+watch_chromium.org, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: drm: Restore cursor in CrtcController::Modeset This re-sets the cursor after every mode change. It will ensure we restore the cursor after returning from frecon. BUG=471097 TEST=Ctrl-Alt-Forward in developer mode to activate frecon, then Ctrl-Alt-Back to return to chrome. Cursor is shown. Committed: https://crrev.com/ee3db43d851c57a6f93bced7178797c0d73f8c84 Cr-Commit-Position: refs/heads/master@{#325243}

Patch Set 1 #

Patch Set 2 : fixup test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -10 lines) Patch
M ui/ozone/platform/drm/gpu/crtc_controller.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/crtc_controller.cc View 1 4 chunks +25 lines, -8 lines 0 comments Download
M ui/ozone/platform/drm/gpu/hardware_display_controller.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (10 generated)
spang
5 years, 8 months ago (2015-04-15 00:37:21 UTC) #2
alexst (slow to review)
lgtm
5 years, 8 months ago (2015-04-15 00:40:04 UTC) #3
dnicoara
lgtm
5 years, 8 months ago (2015-04-15 13:32:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085123002/1
5 years, 8 months ago (2015-04-15 13:32:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085123002/20001
5 years, 8 months ago (2015-04-15 14:49:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085123002/20001
5 years, 8 months ago (2015-04-15 14:54:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085123002/20001
5 years, 8 months ago (2015-04-15 15:10:33 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-15 15:18:35 UTC) #17
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/ee3db43d851c57a6f93bced7178797c0d73f8c84 Cr-Commit-Position: refs/heads/master@{#325243}
5 years, 8 months ago (2015-04-15 15:19:56 UTC) #18
dshwang
This CL broke amd64-generic_freon in qemu :'( +zachr Always black screen with following log [4723:4723:0417/073217:ERROR:crtc_controller.cc(154)] ...
5 years, 8 months ago (2015-04-17 14:37:53 UTC) #20
spang
On 2015/04/17 14:37:53, dshwang wrote: > This CL broke amd64-generic_freon in qemu :'( > +zachr ...
5 years, 8 months ago (2015-04-17 16:30:25 UTC) #21
dshwang
5 years, 8 months ago (2015-04-20 09:59:14 UTC) #22
Message was sent while issue was closed.
On 2015/04/17 16:30:25, spang wrote:
> On 2015/04/17 14:37:53, dshwang wrote:
> > This CL broke amd64-generic_freon in qemu :'(
> > +zachr
> > 
> > Always black screen with following log
> > [4723:4723:0417/073217:ERROR:crtc_controller.cc(154)] drmModeSetCursor:
device
> > /dev/dri/card0 crtc 18 handle 0 size 0x0: No such device or address
> 
> https://codereview.chromium.org/1090263002/

thx for fixing!

Powered by Google App Engine
This is Rietveld 408576698