Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2214)

Unified Diff: chrome/browser/resources/extensions/extension_list.js

Issue 1085113002: [Extensions UI] Use developerPrivate API for repair, options, show path (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/extensions/extension_list.js
diff --git a/chrome/browser/resources/extensions/extension_list.js b/chrome/browser/resources/extensions/extension_list.js
index 637707e0c31e87a92bde6a91c51f53dabc31af1c..a22de30ea9c1c26059da239a1c5d45719457c00e 100644
--- a/chrome/browser/resources/extensions/extension_list.js
+++ b/chrome/browser/resources/extensions/extension_list.js
@@ -449,12 +449,12 @@ cr.define('extensions', function() {
// The 'Options' button or link, depending on its behaviour.
// Set an href to get the correct mouse-over appearance (link,
- // footer) - but the actual link opening is done through chrome.send
- // with a preventDefault().
+ // footer) - but the actual link opening is done through developerPrivate
+ // api with a preventDefault().
not at google - send to devlin 2015/04/16 17:33:25 What's an api? Some kind of animal species? (ok ba
Devlin 2015/04/16 17:59:12 I think it's a mountain in Nepal... though I guess
row.querySelector('.options-link').href =
extension.optionsPage ? extension.optionsPage.url : '';
row.setupColumn('.options-link', 'options', 'click', function(e) {
- chrome.send('extensionSettingsOptions', [extension.id]);
+ chrome.developerPrivate.showOptions(extension.id);
e.preventDefault();
});
@@ -486,7 +486,7 @@ cr.define('extensions', function() {
// The 'Launch' link.
row.setupColumn('.launch-link', 'launch', 'click', function(e) {
- chrome.send('extensionSettingsLaunch', [extension.id]);
+ chrome.management.launchApp(extension.id);
});
// The 'Reload' terminated link.
@@ -498,7 +498,7 @@ cr.define('extensions', function() {
// The 'Repair' corrupted link.
row.setupColumn('.corrupted-repair-button', 'repair', 'click',
function(e) {
- chrome.send('extensionSettingsRepair', [extension.id]);
+ chrome.developerPrivate.repairExtension(extension.id);
});
// The 'Enabled' checkbox.
@@ -553,7 +553,7 @@ cr.define('extensions', function() {
// The path, if provided by unpacked extension.
row.setupColumn('.load-path a:first-of-type', 'dev-loadPath', 'click',
function(e) {
- chrome.send('extensionSettingsShowPath', [String(extension.id)]);
+ chrome.developerPrivate.showPath(extension.id);
e.preventDefault();
});

Powered by Google App Engine
This is Rietveld 408576698