[Extensions UI] Use developerPrivate API for repair, options, show path

chrome/browser/resources/extensions/extension_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="extension_error.js">
 
 ///////////////////////////////////////////////////////////////////////////////
 // ExtensionFocusRow:
 
 /**
@@ skipping 431 matching lines @@
       row.setupColumn('.file-access-control input', 'localUrls', 'click',
                       function(e) {
         chrome.developerPrivate.updateExtensionConfiguration({
           extensionId: extension.id,
           fileAccess: e.target.checked
         });
       });
 
       // The 'Options' button or link, depending on its behaviour.
       // Set an href to get the correct mouse-over appearance (link,
-      // footer) - but the actual link opening is done through chrome.send
-      // with a preventDefault().
+      // footer) - but the actual link opening is done through developerPrivate
+      // api with a preventDefault().

[not at google - send to devlin, 2015/04/16 17:33:25]

What's an api? Some kind of animal species? (ok basically everybody is guilty of
not acronymising API all the time).

[Devlin, 2015/04/16 17:59:12]

I think it's a mountain in Nepal... though I guess even that would be Api. 
Done.

       row.querySelector('.options-link').href =
           extension.optionsPage ? extension.optionsPage.url : '';
       row.setupColumn('.options-link', 'options', 'click', function(e) {
-        chrome.send('extensionSettingsOptions', [extension.id]);
+        chrome.developerPrivate.showOptions(extension.id);
         e.preventDefault();
       });
 
       row.setupColumn('.options-button', 'options', 'click', function(e) {
         this.showEmbeddedExtensionOptions_(extension.id, false);
         e.preventDefault();
       }.bind(this));
 
       // The 'View in Web Store/View Web Site' link.
       row.querySelector('.site-link').setAttribute('column-type', 'website');
@@ skipping 11 matching lines @@
       });
 
       // The 'Reload' link.
       row.setupColumn('.reload-link', 'localReload', 'click', function(e) {
         chrome.developerPrivate.reload(extension.id, {failQuietly: true});
         extensionReloadedTimestamp[extension.id] = Date.now();
       });
 
       // The 'Launch' link.
       row.setupColumn('.launch-link', 'launch', 'click', function(e) {
-        chrome.send('extensionSettingsLaunch', [extension.id]);
+        chrome.management.launchApp(extension.id);
       });
 
       // The 'Reload' terminated link.
       row.setupColumn('.terminated-reload-link', 'terminatedReload', 'click',
                       function(e) {
         chrome.developerPrivate.reload(extension.id, {failQuietly: true});
       });
 
       // The 'Repair' corrupted link.
       row.setupColumn('.corrupted-repair-button', 'repair', 'click',
                       function(e) {
-        chrome.send('extensionSettingsRepair', [extension.id]);
+        chrome.developerPrivate.repairExtension(extension.id);
       });
 
       // The 'Enabled' checkbox.
       row.setupColumn('.enable-checkbox input', 'enabled', 'change',
                       function(e) {
         var checked = e.target.checked;
         // TODO(devlin): What should we do if this fails?
         chrome.management.setEnabled(extension.id, checked);
 
         // This may seem counter-intuitive (to not set/clear the checkmark)
@@ skipping 34 matching lines @@
           }
         }.bind(this));
       }.bind(this));
       row.querySelector('.enable-controls').appendChild(trash);
 
       // Developer mode ////////////////////////////////////////////////////////
 
       // The path, if provided by unpacked extension.
       row.setupColumn('.load-path a:first-of-type', 'dev-loadPath', 'click',
                       function(e) {
-        chrome.send('extensionSettingsShowPath', [String(extension.id)]);
+        chrome.developerPrivate.showPath(extension.id);
         e.preventDefault();
       });
 
       // Maintain the order that nodes should be in when creating as well as
       // when adding only one new row.
       this.insertBefore(row, nextNode);
       this.updateNode_(extension, row);
     },
 
     /**
@@ skipping 490 matching lines @@
         var nextExt = this.extensions_[this.extensions_.indexOf(extension) + 1];
         this.createNode_(extension, nextExt ? $(nextExt.id) : null);
       }
     }
   };
 
   return {
     ExtensionList: ExtensionList
   };
 });