[Extensions UI] Use developerPrivate API for repair, options, show path

[Extensions UI] Use developerPrivate API for repair, options, show path

Add developerPrivate API functions for repairing a corrupt extension,
showing extension options, and showing an extension's path, and
update the chrome://extensions page to use those.
Also update the chrome://extensions page to use existing
api functions for launching an app and auto-updating.

BUG=461039
Committed: https://crrev.com/b2eb97880d384168ae17cfe24b3c874d72428141
Cr-Commit-Position: refs/heads/master@{#325563}

[Devlin, 2015-04-15 00:54:08]

Patchset #1 (id:1) has been deleted

[Devlin, 2015-04-15 00:57:04]

rdevlin.cronin@chromium.org changed reviewers:
+ kalman@chromium.org

[Devlin, 2015-04-15 00:57:04]

These are all pretty straight-forward, copy-paste style conversions, so
hopefully not too hard. :)

[not at google - send to devlin, 2015-04-16 17:33:25]

copy-paste lgtm with a couple of tiny cleanups

https://codereview.chromium.org/1085113002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/developer_private/developer_private_api.cc
(right):

https://codereview.chromium.org/1085113002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:1314:
Respond(NoArguments());
There is a single precedent in this file to do Respond(success ? NoArguments() :
Error(error)) but up to you :-)

https://codereview.chromium.org/1085113002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:1325:
params->extension_id);
Use GetExtensionById?

https://codereview.chromium.org/1085113002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/extensions/extension_list.js (right):

https://codereview.chromium.org/1085113002/diff/20001/chrome/browser/resource...
chrome/browser/resources/extensions/extension_list.js:453: // api with a
preventDefault().
What's an api? Some kind of animal species? (ok basically everybody is guilty of
not acronymising API all the time).

https://codereview.chromium.org/1085113002/diff/20001/chrome/common/extension...
File chrome/common/extensions/api/developer_private.idl (right):

https://codereview.chromium.org/1085113002/diff/20001/chrome/common/extension...
chrome/common/extensions/api/developer_private.idl:502: // | extensionId | : The
id of the extension to repair.
Should be |extensionId| not | extensionId |, could you update the
deleteExtensionErrors to use that style as well?

[Devlin, 2015-04-16 17:59:12]

https://codereview.chromium.org/1085113002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/developer_private/developer_private_api.cc
(right):

https://codereview.chromium.org/1085113002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:1314:
Respond(NoArguments());
On 2015/04/16 17:33:25, kalman wrote:
> There is a single precedent in this file to do Respond(success ? NoArguments()
:
> Error(error)) but up to you :-)

Done.

https://codereview.chromium.org/1085113002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:1325:
params->extension_id);
On 2015/04/16 17:33:25, kalman wrote:
> Use GetExtensionById?

Well, we only want enabled extensions. But maybe this one makes it work making a
GetEnabledExtensionById. Done.

https://codereview.chromium.org/1085113002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/extensions/extension_list.js (right):

https://codereview.chromium.org/1085113002/diff/20001/chrome/browser/resource...
chrome/browser/resources/extensions/extension_list.js:453: // api with a
preventDefault().
On 2015/04/16 17:33:25, kalman wrote:
> What's an api? Some kind of animal species? (ok basically everybody is guilty
of
> not acronymising API all the time).

I think it's a mountain in Nepal... though I guess even that would be Api. 
Done.

https://codereview.chromium.org/1085113002/diff/20001/chrome/common/extension...
File chrome/common/extensions/api/developer_private.idl (right):

https://codereview.chromium.org/1085113002/diff/20001/chrome/common/extension...
chrome/common/extensions/api/developer_private.idl:502: // | extensionId | : The
id of the extension to repair.
On 2015/04/16 17:33:25, kalman wrote:
> Should be |extensionId| not | extensionId |, could you update the
> deleteExtensionErrors to use that style as well?

Done. I keep forgetting if it's the || that need a space or the : for IDL to
parse it correctly (it's the :).

Okay, that just looked like a bunch of random symbols...

[Devlin, 2015-04-16 17:59:56]

rdevlin.cronin@chromium.org changed reviewers:
+ dbeam@chromium.org, mpearson@chromium.org

[Devlin, 2015-04-16 17:59:57]

+Dan for closure_compiler
+Mark for histograms

[Dan Beam, 2015-04-16 18:04:15]

lgtm

https://codereview.chromium.org/1085113002/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/developer_private/developer_private_api.cc
(right):

https://codereview.chromium.org/1085113002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:1327:
return RespondNow(Error(kNoSuchExtensionError));
nit: \n

https://codereview.chromium.org/1085113002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:1329:
return RespondNow(Error(kNoOptionsPageForExtensionError));
nit: \n

https://codereview.chromium.org/1085113002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:1332:
return RespondNow(Error(kCouldNotFindWebContentsError));
nit: \n

[Mark P, 2015-04-16 18:53:05]

histograms.xml lgtm

[Devlin, 2015-04-16 22:22:34]

https://codereview.chromium.org/1085113002/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/api/developer_private/developer_private_api.cc
(right):

https://codereview.chromium.org/1085113002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:1327:
return RespondNow(Error(kNoSuchExtensionError));
On 2015/04/16 18:04:15, Dan Beam wrote:
> nit: \n

Done.

https://codereview.chromium.org/1085113002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:1329:
return RespondNow(Error(kNoOptionsPageForExtensionError));
On 2015/04/16 18:04:15, Dan Beam wrote:
> nit: \n

Done.

https://codereview.chromium.org/1085113002/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/api/developer_private/developer_private_api.cc:1332:
return RespondNow(Error(kCouldNotFindWebContentsError));
On 2015/04/16 18:04:15, Dan Beam wrote:
> nit: \n

Done.

[Devlin, 2015-04-16 22:22:38]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2015-04-16 22:22:38]

The patchset sent to the CQ was uploaded after l-g-t-m from kalman@chromium.org,
mpearson@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1085113002/#ps60001
(title: "Dan's")

[commit-bot: I haz the power, 2015-04-16 22:25:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1085113002/60001

[commit-bot: I haz the power, 2015-04-16 22:42:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-16 22:42:27]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  win8_chromium_rel on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[Devlin, 2015-04-16 22:48:27]

Patchset #4 (id:80001) has been deleted

[Devlin, 2015-04-16 22:56:24]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2015-04-16 22:56:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
mpearson@chromium.org, dbeam@chromium.org, kalman@chromium.org
Link to the patchset: https://codereview.chromium.org/1085113002/#ps100001
(title: "Rebase")

[commit-bot: I haz the power, 2015-04-16 22:56:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1085113002/100001

[commit-bot: I haz the power, 2015-04-17 00:14:08]

Committed patchset #4 (id:100001)

[commit-bot: I haz the power, 2015-04-17 00:15:29]

Patchset 4 (id:??) landed as
https://crrev.com/b2eb97880d384168ae17cfe24b3c874d72428141
Cr-Commit-Position: refs/heads/master@{#325563}