Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 1085093002: Remove a couple of unused methods from sel_ldr_launcher_base. (Closed)

Created:
5 years, 8 months ago by jvoung (off chromium)
Modified:
5 years, 8 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Remove a couple of unused methods from SelLdrLauncherBase. (*) StartModuleAndSetupAppChannel -- StartModule and SetupAppChannel can just be called separately (though only called by sel_universal and the sel_main_chrome_test). They aren't used by Chrome. (*) SetupCommandAndLoad -- SetupCommand is used by chrome, and LoadModule is only used by sel_universal. Could have been called separately. (*) Wrap(), WrapCleanup(), secure_socket_addr() aren't used. (*) ConnectBootstrapSocket and RetrieveSockAddr are used internally so make them private. (*) Add "private" to make some lint checks happy with the DISALLOW_COPY_AND_ASSIGN. BUG=none R=mseaborn@chromium.org Committed: https://chromium.googlesource.com/native_client/src/native_client/+/9e6f51021bdf1a395b072bcea94d55787511d301

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -65 lines) Patch
M src/trusted/nonnacl_util/sel_ldr_launcher.h View 3 chunks +8 lines, -24 lines 0 comments Download
M src/trusted/nonnacl_util/sel_ldr_launcher_base.cc View 4 chunks +2 lines, -39 lines 0 comments Download
M tests/sel_main_chrome/sel_main_chrome_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
jvoung (off chromium)
5 years, 8 months ago (2015-04-14 23:55:35 UTC) #2
Mark Seaborn
LGTM
5 years, 8 months ago (2015-04-15 02:42:28 UTC) #3
jvoung (off chromium)
5 years, 8 months ago (2015-04-15 18:45:00 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9e6f51021bdf1a395b072bcea94d55787511d301 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698