Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 1085073002: Revert of Disable WebGL conformance test on Win8/NVIDIA (Closed)

Created:
5 years, 8 months ago by hendrikw
Modified:
5 years, 8 months ago
Reviewers:
Zhenyao Mo, ccameron
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable WebGL conformance test on Win8/NVIDIA (patchset #3 id:40001 of https://codereview.chromium.org/930423002/) Reason for revert: kbr@ doesn't think this is needed anymore, and it might be a cause of us missing real issues. I'll try reverting it, and keep an eye on it. Original issue's description: > Disable WebGL conformance test on Win8/NVIDIA > > The test: > conformance_textures_tex_image_and_sub_image_2d_with_array_buffer_view > > Has been timing out on and off for as long as we have records. > > BUG=459265 > NOPRESUBMIT=True > > Committed: https://crrev.com/777a126ec7c9fbd50c4f62b27de648e5b306fc7d > Cr-Commit-Position: refs/heads/master@{#316872} TBR=zmo@chromium.org,ccameron@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=459265 Committed: https://crrev.com/997ea6c612de165623240c058f9e4e89ced7f702 Cr-Commit-Position: refs/heads/master@{#325142}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M content/test/gpu/gpu_tests/webgl_conformance_expectations.py View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
hendrikw
Created Revert of Disable WebGL conformance test on Win8/NVIDIA
5 years, 8 months ago (2015-04-14 22:22:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085073002/1
5 years, 8 months ago (2015-04-14 22:36:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-14 22:37:16 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/997ea6c612de165623240c058f9e4e89ced7f702 Cr-Commit-Position: refs/heads/master@{#325142}
5 years, 8 months ago (2015-04-14 22:38:26 UTC) #5
johnme
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1082203004/ by johnme@chromium.org. ...
5 years, 8 months ago (2015-04-16 13:47:22 UTC) #6
hendrikw
On 2015/04/16 13:47:22, johnme wrote: > A revert of this CL (patchset #1 id:1) has ...
5 years, 8 months ago (2015-04-16 15:17:46 UTC) #7
hendrikw
5 years, 8 months ago (2015-04-16 15:20:05 UTC) #8
Message was sent while issue was closed.
On 2015/04/16 15:17:46, hendrikw wrote:
> On 2015/04/16 13:47:22, johnme wrote:
> > A revert of this CL (patchset #1 id:1) has been created in
> > https://codereview.chromium.org/1082203004/ by mailto:johnme@chromium.org.
> > 
> > The reason for reverting is: Still very flaky on Win Nvidia:
> > 
> >
>
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=....
> 
> I'm not sure why you reverted this.  Only win8 is disabled by this test, and
> it's not that flaky.  win7, however is flaky, and there are other changes
going
> in that should resolve that.

I see, it is all win (comment said win 8).  I guess I'll revert this revert
after the webgl change rolls in.

Powered by Google App Engine
This is Rietveld 408576698