Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 1085023003: Don't use NEON optimized code in lpng_v163 (Closed)

Created:
5 years, 8 months ago by Sam Clegg
Modified:
5 years, 8 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't use NEON optimized code in lpng_v163 The source files required to use the NEON function are not included so we should not try to reference those symbols. BUG=477162 TEST=ninja -C out_arm/Release/ pdfium_diff R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/b3300162a1ebacc973ff9793029caf4db9a4f5e5

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M AUTHORS View 1 2 chunks +2 lines, -1 line 0 comments Download
M samples/fx_lpng/lpng_v163/pngpriv.h View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Sam Clegg
If you prefer we could instead include the missing .c files from libpng 1.6.3?
5 years, 8 months ago (2015-04-15 01:04:12 UTC) #2
Tom Sepez
lgtm
5 years, 8 months ago (2015-04-15 16:39:28 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 8 months ago (2015-04-15 17:17:16 UTC) #6
Tom Sepez
On 2015/04/15 17:17:16, I haz the power (commit-bot) wrote: > Commit queue rejected this change ...
5 years, 8 months ago (2015-04-15 17:23:36 UTC) #7
Sam Clegg
On 2015/04/15 17:23:36, Tom Sepez wrote: > On 2015/04/15 17:17:16, I haz the power (commit-bot) ...
5 years, 8 months ago (2015-04-15 17:24:43 UTC) #8
Tom Sepez
On 2015/04/15 17:24:43, Sam Clegg wrote: > added myself to AUTRORS too. Is that the ...
5 years, 8 months ago (2015-04-15 17:26:46 UTC) #9
Sam Clegg
On 2015/04/15 17:26:46, Tom Sepez wrote: > On 2015/04/15 17:24:43, Sam Clegg wrote: > > ...
5 years, 8 months ago (2015-04-15 17:32:05 UTC) #10
Sam Clegg
Committed patchset #2 (id:20001) manually as b3300162a1ebacc973ff9793029caf4db9a4f5e5 (presubmit successful).
5 years, 8 months ago (2015-04-15 17:53:13 UTC) #11
Sam Clegg
5 years, 8 months ago (2015-04-15 17:58:59 UTC) #12
Message was sent while issue was closed.
On 2015/04/15 17:53:13, Sam Clegg wrote:
> Committed patchset #2 (id:20001) manually as
> b3300162a1ebacc973ff9793029caf4db9a4f5e5 (presubmit successful).

What script do you guys use to roll DEPS?

Powered by Google App Engine
This is Rietveld 408576698