Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1085003002: pepper: VideoEncoder: use same constraints as media::VideoFrame for software encoder (Closed)

Created:
5 years, 8 months ago by llandwerlin-old
Modified:
5 years, 8 months ago
Reviewers:
bbudge
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

pepper: VideoEncoder: use same constraints as media::VideoFrame for software encoder Prevent the software encoder to accept odd sized video frames by reusing the same constraints applied to frames allocated by media::VideoFrame. BUG=455409 Committed: https://crrev.com/a460cbb69ccd575bb70ec36874a13f802fabe429 Cr-Commit-Position: refs/heads/master@{#325266}

Patch Set 1 #

Total comments: 2

Patch Set 2 : bbudge's review + windows failure #

Patch Set 3 : Fix invalid assert #

Patch Set 4 : Do not wait on invalid callback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M content/renderer/pepper/video_encoder_shim.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M ppapi/tests/test_video_encoder.cc View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
llandwerlin-old
PTAL, Thanks.
5 years, 8 months ago (2015-04-14 17:23:27 UTC) #2
bbudge
https://codereview.chromium.org/1085003002/diff/1/content/renderer/pepper/video_encoder_shim.cc File content/renderer/pepper/video_encoder_shim.cc (right): https://codereview.chromium.org/1085003002/diff/1/content/renderer/pepper/video_encoder_shim.cc#newcode75 content/renderer/pepper/video_encoder_shim.cc:75: gfx::Size coded_size_; I don't see coded_size_ used anywhere else. ...
5 years, 8 months ago (2015-04-14 17:42:52 UTC) #3
llandwerlin-old
https://codereview.chromium.org/1085003002/diff/1/content/renderer/pepper/video_encoder_shim.cc File content/renderer/pepper/video_encoder_shim.cc (right): https://codereview.chromium.org/1085003002/diff/1/content/renderer/pepper/video_encoder_shim.cc#newcode75 content/renderer/pepper/video_encoder_shim.cc:75: gfx::Size coded_size_; On 2015/04/14 17:42:51, bbudge wrote: > I ...
5 years, 8 months ago (2015-04-15 09:36:50 UTC) #4
bbudge
LGTM
5 years, 8 months ago (2015-04-15 17:24:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1085003002/60001
5 years, 8 months ago (2015-04-15 17:25:47 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-15 17:30:04 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 17:31:20 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/a460cbb69ccd575bb70ec36874a13f802fabe429
Cr-Commit-Position: refs/heads/master@{#325266}

Powered by Google App Engine
This is Rietveld 408576698