Chromium Code Reviews

Issue 1084983002: [strong] Implement static restrictions on switch statement (Closed)

Created:
5 years, 8 months ago by conradw
Modified:
5 years, 8 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] Implement static restrictions on switch statement Implements the strong mode proposal's restrictions on the syntax of the switch statement. Also fixes a minor bug with empty statements in strong mode and improves StrongUndefinedArrow parser synch tests. BUG=v8:3956 LOG=N Committed: https://crrev.com/d8bccfe974a67c6672d4596fa438cb0c83eee8ba Cr-Commit-Position: refs/heads/master@{#27885}

Patch Set 1 #

Total comments: 10

Patch Set 2 : cl feedback #

Patch Set 3 : fix scope issue #

Total comments: 20

Patch Set 4 : cl feedback 2 #

Patch Set 5 : minor rename #

Patch Set 6 : fixed my broken tests #

Total comments: 15

Patch Set 7 : cl feedback 3 #

Unified diffs Side-by-side diffs Stats (+290 lines, -57 lines)
M src/messages.js View 1 chunk +1 line, -0 lines 0 comments
M src/parser.h View 1 chunk +2 lines, -0 lines 0 comments
M src/parser.cc View 5 chunks +47 lines, -25 lines 0 comments
M src/preparser.h View 2 chunks +9 lines, -0 lines 0 comments
M src/preparser.cc View 9 chunks +30 lines, -12 lines 0 comments
M test/cctest/test-parsing.cc View 3 chunks +91 lines, -20 lines 0 comments
A test/mjsunit/strong/switch.js View 1 chunk +110 lines, -0 lines 0 comments

Messages

Total messages: 17 (3 generated)
conradw
On 2015/04/14 16:35:59, conradw wrote: > mailto:conradw@chromium.org changed reviewers: > + mailto:rossberg@chromium.org PTAL The error ...
5 years, 8 months ago (2015-04-14 16:36:21 UTC) #2
rossberg
Did you forget to git add the JS test by any chance? https://codereview.chromium.org/1084983002/diff/1/src/ast.h File src/ast.h ...
5 years, 8 months ago (2015-04-14 20:19:50 UTC) #3
conradw
Oops! I did forget to add the JS tests. https://codereview.chromium.org/1084983002/diff/1/src/ast.h File src/ast.h (right): https://codereview.chromium.org/1084983002/diff/1/src/ast.h#newcode283 src/ast.h:283: ...
5 years, 8 months ago (2015-04-15 11:40:03 UTC) #4
conradw
PTAL, unbroke it
5 years, 8 months ago (2015-04-15 17:27:47 UTC) #6
rossberg
https://codereview.chromium.org/1084983002/diff/60001/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/1084983002/diff/60001/src/parser.cc#newcode1886 src/parser.cc:1886: Statement* Parser::ParseWrappedStatement(ZoneList<const AstRawString*>* labels, In fact, I would just ...
5 years, 8 months ago (2015-04-15 19:56:35 UTC) #7
arv (Not doing code reviews)
Where is the changes to Parser? I only see changes to the preparser.
5 years, 8 months ago (2015-04-15 20:55:32 UTC) #8
rossberg
On 2015/04/15 20:55:32, arv wrote: > Where is the changes to Parser? I only see ...
5 years, 8 months ago (2015-04-16 07:37:43 UTC) #9
conradw
https://codereview.chromium.org/1084983002/diff/60001/src/parser.cc File src/parser.cc (right): https://codereview.chromium.org/1084983002/diff/60001/src/parser.cc#newcode1886 src/parser.cc:1886: Statement* Parser::ParseWrappedStatement(ZoneList<const AstRawString*>* labels, On 2015/04/15 19:56:34, rossberg wrote: ...
5 years, 8 months ago (2015-04-16 10:59:57 UTC) #10
rossberg
Almost there, just a few tweaks to the tests. https://codereview.chromium.org/1084983002/diff/120001/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/1084983002/diff/120001/test/cctest/test-parsing.cc#newcode6044 test/cctest/test-parsing.cc:6044: ...
5 years, 8 months ago (2015-04-16 12:01:16 UTC) #11
conradw
https://codereview.chromium.org/1084983002/diff/120001/test/cctest/test-parsing.cc File test/cctest/test-parsing.cc (right): https://codereview.chromium.org/1084983002/diff/120001/test/cctest/test-parsing.cc#newcode6044 test/cctest/test-parsing.cc:6044: NULL}; On 2015/04/16 12:01:16, rossberg wrote: > Can you ...
5 years, 8 months ago (2015-04-16 12:34:21 UTC) #12
rossberg
lgtm
5 years, 8 months ago (2015-04-16 13:26:15 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1084983002/140001
5 years, 8 months ago (2015-04-16 13:26:40 UTC) #15
commit-bot: I haz the power
Committed patchset #7 (id:140001)
5 years, 8 months ago (2015-04-16 13:29:34 UTC) #16
commit-bot: I haz the power
5 years, 8 months ago (2015-04-16 13:29:46 UTC) #17
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/d8bccfe974a67c6672d4596fa438cb0c83eee8ba
Cr-Commit-Position: refs/heads/master@{#27885}

Powered by Google App Engine