Source/modules/wake_lock/DocumentWakeLock.cpp - Issue 1084923002: Wake Lock API implementation (Blink part)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/wake_lock/DocumentWakeLock.cpp

Issue 1084923002: Wake Lock API implementation (Blink part) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Applied review comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« Source/bindings/templates/interface_base.cpp ('K') | « Source/modules/wake_lock/DocumentWakeLock.h ('k') | Source/modules/wake_lock/DocumentWakeLock.idl » ('j') | Source/modules/wake_lock/WakeLock.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "config.h"

	6 #include "modules/wake_lock/DocumentWakeLock.h"

	7

	8 #include "modules/wake_lock/WakeLock.h"

	9

	10 namespace blink {

	11

	12 bool DocumentWakeLock::keepScreenAwake(Document& document)

	13 {

	14 return WakeLock::keepScreenAwake(document);
	mlamouri (slow - plz ping) 2015/05/05 13:45:43 Would it make sense to return false if document.fr Would it make sense to return false if document.frame() is null? alogvinov 2015/05/05 16:22:27 A web page could potentially create a detached doc Show quoted text On 2015/05/05 13:45:43, Mounir Lamouri wrote: > Would it make sense to return false if document.frame() is null? A web page could potentially create a detached document via document.implementation.createHTMLDocument() and set keepScreenAwake flag on it, then read it back, which works for the implementation presented here. This is hardly useful, of course, but nevertheless possible. I will add a layout test to the next CL to demonstrate it (and if we decide to use default value for keepScreenAwake, we can modify this test accordingly to specify the behavior).
	15 }

	16

	17 void DocumentWakeLock::setKeepScreenAwake(Document& document, bool keepScreenAwa ke)

	18 {

	19 WakeLock::setKeepScreenAwake(document, keepScreenAwake);
	mlamouri (slow - plz ping) 2015/05/05 13:45:43 Would it make sense to make it a no-op if document Would it make sense to make it a no-op if document.frame() is null?
	20 }

	21

	22 } // namespace blink

OLD	NEW