LayoutTests/wake_lock/wakelock-api.html - Issue 1084923002: Wake Lock API implementation (Blink part)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/wake_lock/wakelock-api.html

Issue 1084923002: Wake Lock API implementation (Blink part) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <script src="../resources/testharness.js"></script>

	5 <script src="../resources/testharnessreport.js"></script>

	6 <script>

	7

	8 test(function() {

	9 assert_true('keepScreenAwake' in window.document);
	mlamouri (slow - plz ping) 2015/04/28 08:00:25 There are methods that are meant to check if somet There are methods that are meant to check if something is present in an object. Look at similar tests.
	10 assert_true(typeof document.keepScreenAwake !== 'undefined');

	11 assert_true(typeof document.keepScreenAwake === 'boolean');
	mlamouri (slow - plz ping) 2015/04/28 08:00:25 No need to test !== undefined and === boolean. No need to test !== undefined and === boolean.
	12 assert_equals(typeof document.keepScreenAwake, 'boolean');

	13 }, 'Test that the WakeLock API is present.')

	14

	15 test(function() {

	16 var caught = false;

	17 try {

	18 document.keepScreenAwake = false;

	19 document.keepScreenAwake = true;

	20 } catch (e) {

	21 caught = true;

	22 }

	23

	24 assert_false(caught);

	25 }, 'Test that document.keepScreenAwake doesn\'t throw when set the value');
	mlamouri (slow - plz ping) 2015/04/28 08:00:25 You can remove that test. If it were to throw, the You can remove that test. If it were to throw, the next test will fail anyway.
	26

	27 test(function() {

	28 document.keepScreenAwake = true;

	29 assert_true(document.keepScreenAwake);

	30

	31 document.keepScreenAwake = false;

	32 assert_false(document.keepScreenAwake);

	33 }, 'Test that document.keepScreenAwake save value');

	34

	35 </script>

	36 </body>

	37 </html>

OLD	NEW