Implementing screenshare bypass flag on Mac.

chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.h"
 
 #include "base/bind.h"
+#include "base/command_line.h"
 #import "base/mac/bundle_locations.h"
 #include "base/strings/sys_string_conversions.h"
 #import "chrome/browser/ui/cocoa/media_picker/desktop_media_picker_item.h"
+#include "chrome/common/chrome_switches.h"
 #include "chrome/grit/generated_resources.h"
 #include "content/public/browser/browser_thread.h"
 #import "third_party/google_toolbox_for_mac/src/AppKit/GTMUILocalizerAndLayoutTweaker.h"
 #import "ui/base/cocoa/flipped_view.h"
 #import "ui/base/cocoa/window_size_constants.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/image/image_skia_util_mac.h"
 
 namespace {
 
@@ skipping 255 matching lines @@
 
 - (void)sourceAddedAtIndex:(int)index {
   const DesktopMediaList::Source& source = media_list_->GetSource(index);
   NSString* imageTitle = base::SysUTF16ToNSString(source.name);
   base::scoped_nsobject<DesktopMediaPickerItem> item(
       [[DesktopMediaPickerItem alloc] initWithSourceId:source.id
                                               imageUID:++lastImageUID_
                                             imageTitle:imageTitle]);
   [items_ insertObject:item atIndex:index];
   [sourceBrowser_ reloadData];
+
+  NSString* autoselectSource = base::SysUTF8ToNSString(
+      base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
+          switches::kAutoSelectDesktopCaptureSource));
+
+  if ([autoselectSource isEqualToString:imageTitle]) {
+    [self reportResult:[item sourceID]];

[phoglund_chromium, 2015/04/14 12:41:22]

I assume here it's OK to do this on this thread and that I don't have to
PostTask it anywhere. It seemed to work fine when I tested it, but I'm a total
objc newbie. Review with care :)

[groby-ooo-7-16, 2015/04/14 15:01:21]

It *should* be OK. sourceAddedAtIndex definitely has to be called on the UI
thread, or strange things happen. Same goes for closing.

I'm worried about the |bridge_| not being reset, though. Technically,
|media_list_| could be reporting more items after we close here. AIUI,
DesktopMediaList doesn't have a StopUpdating() call - that _probably_ means you
need to reset |media_list_| when closing. 

dcaiafa@, any thoughts?

[dcaiafa, 2015/04/22 20:32:42]

It's been a while since I looked at this code, but I looked around and I think
this is fine. No need to reset |media_list_|. It's by design that the window
could be closed while new sources are being reported.

+    [self close];
+  }
 }
 
 - (void)sourceRemovedAtIndex:(int)index {
   if ([[sourceBrowser_ selectionIndexes] containsIndex:index]) {
     // Selected item was removed. Clear selection.
     [sourceBrowser_ setSelectionIndexes:[NSIndexSet indexSet]
                       byExtendingSelection:FALSE];
   }
   [items_ removeObjectAtIndex:index];
   [sourceBrowser_ reloadData];
@@ skipping 17 matching lines @@
 - (void)sourceThumbnailChangedAtIndex:(int)index {
   const DesktopMediaList::Source& source = media_list_->GetSource(index);
   NSImage* image = gfx::NSImageFromImageSkia(source.thumbnail);
 
   DesktopMediaPickerItem* item = [items_ objectAtIndex:index];
   [item setImageRepresentation:image];
   [sourceBrowser_ reloadData];
 }
 
 @end  // @interface DesktopMediaPickerController