Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 1084903002: Fix horizontal scroll tab-switching behavior on Linux (Closed)

Created:
5 years, 8 months ago by hashimoto
Modified:
5 years, 2 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix horizontal scroll tab-switching behavior on Linux The tab on the left side should be selected when scrolling to left and vice versa. BUG=365501 TEST=Prepare a mouse with horizontal-scrolling feature, open multiple tabs, place cursor over tab strip and try to switch tabs. Committed: https://crrev.com/ece9b5e4d3e45d874d893f8422be0796c26bb702 Cr-Commit-Position: refs/heads/master@{#325260}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/views/frame/browser_root_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
hashimoto
sky@, could you review this change? This shouldn't affect any platforms other than Linux as ...
5 years, 8 months ago (2015-04-14 12:39:17 UTC) #2
sky
This LGTM, but Sadrul added this code. Sadrul, does the flip seem right to you? ...
5 years, 8 months ago (2015-04-14 19:52:35 UTC) #4
hashimoto
Sending to the right address. sadrul@, how does this change look to you?
5 years, 8 months ago (2015-04-15 10:03:41 UTC) #6
sadrul
Yeah, this lgtm.
5 years, 8 months ago (2015-04-15 14:40:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1084903002/1
5 years, 8 months ago (2015-04-15 15:34:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 16:31:29 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 16:32:16 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ece9b5e4d3e45d874d893f8422be0796c26bb702
Cr-Commit-Position: refs/heads/master@{#325260}

Powered by Google App Engine
This is Rietveld 408576698