Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Issue 1084873003: Update extension docs for options V2 to mention chrome.runtime.openOptionsPage. (Closed)

Created:
5 years, 8 months ago by not at google - send to devlin
Modified:
5 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update extension docs for options V2 to mention chrome.runtime.openOptionsPage. BUG=430054 R=rockot@chromium.org Committed: https://crrev.com/79c734ba9f56df8670dcf75b0acb7e2e415c7126 Cr-Commit-Position: refs/heads/master@{#325275}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -16 lines) Patch
M chrome/common/extensions/docs/templates/articles/optionsV2.html View 1 1 chunk +27 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
not at google - send to devlin
See https://developer.chrome.com/_patch/1084873003/extensions/optionsV2#considerations
5 years, 8 months ago (2015-04-14 23:26:45 UTC) #1
not at google - send to devlin
See https://developer.chrome.com/_patch/1084873003/extensions/optionsV2#considerations
5 years, 8 months ago (2015-04-14 23:26:45 UTC) #2
not at google - send to devlin
ping
5 years, 8 months ago (2015-04-15 16:20:43 UTC) #3
Ken Rockot(use gerrit already)
lgtm
5 years, 8 months ago (2015-04-15 17:27:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1084873003/20001
5 years, 8 months ago (2015-04-15 17:41:57 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-15 18:11:36 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 18:14:26 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/79c734ba9f56df8670dcf75b0acb7e2e415c7126
Cr-Commit-Position: refs/heads/master@{#325275}

Powered by Google App Engine
This is Rietveld 408576698