Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 1084853002: Fix Math.log10 implementation for 1 - Number.EPSILON. (Closed)

Created:
5 years, 8 months ago by Yang
Modified:
5 years, 8 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix Math.log10 implementation for 1 - Number.EPSILON. R=svenpanne@chromium.org BUG=v8:4025 LOG=N Committed: https://crrev.com/2c01bd34b03cefe3946147aaf626f9e9938ee63e Cr-Commit-Position: refs/heads/master@{#27815}

Patch Set 1 #

Patch Set 2 : preliminary fix for the test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/third_party/fdlibm/fdlibm.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/es6/math-log2-log10.js View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Yang
5 years, 8 months ago (2015-04-14 06:09:17 UTC) #1
Sven Panne
lgtm
5 years, 8 months ago (2015-04-14 06:10:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1084853002/1
5 years, 8 months ago (2015-04-14 06:10:21 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/1759)
5 years, 8 months ago (2015-04-14 06:20:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1084853002/20001
5 years, 8 months ago (2015-04-14 11:32:20 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-14 11:56:14 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 11:56:27 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2c01bd34b03cefe3946147aaf626f9e9938ee63e
Cr-Commit-Position: refs/heads/master@{#27815}

Powered by Google App Engine
This is Rietveld 408576698