Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 108483008: Make RenderFrameHostManager swap RenderFrameHosts, not RenderViewHosts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/frame_host/render_frame_host_impl.h" 5 #include "content/browser/frame_host/render_frame_host_impl.h"
6 6
7 #include "base/containers/hash_tables.h" 7 #include "base/containers/hash_tables.h"
8 #include "base/lazy_instance.h" 8 #include "base/lazy_instance.h"
9 #include "content/browser/frame_host/frame_tree.h" 9 #include "content/browser/frame_host/frame_tree.h"
10 #include "content/browser/frame_host/frame_tree_node.h" 10 #include "content/browser/frame_host/frame_tree_node.h"
(...skipping 30 matching lines...) Expand all
41 FrameTree* frame_tree, 41 FrameTree* frame_tree,
42 FrameTreeNode* frame_tree_node, 42 FrameTreeNode* frame_tree_node,
43 int routing_id, 43 int routing_id,
44 bool is_swapped_out) 44 bool is_swapped_out)
45 : render_view_host_(render_view_host), 45 : render_view_host_(render_view_host),
46 delegate_(delegate), 46 delegate_(delegate),
47 frame_tree_(frame_tree), 47 frame_tree_(frame_tree),
48 frame_tree_node_(frame_tree_node), 48 frame_tree_node_(frame_tree_node),
49 routing_id_(routing_id), 49 routing_id_(routing_id),
50 is_swapped_out_(is_swapped_out) { 50 is_swapped_out_(is_swapped_out) {
51 frame_tree_->RegisterRenderFrameHost(this);
51 GetProcess()->AddRoute(routing_id_, this); 52 GetProcess()->AddRoute(routing_id_, this);
52 g_routing_id_frame_map.Get().insert(std::make_pair( 53 g_routing_id_frame_map.Get().insert(std::make_pair(
53 RenderFrameHostID(GetProcess()->GetID(), routing_id_), 54 RenderFrameHostID(GetProcess()->GetID(), routing_id_),
54 this)); 55 this));
55 } 56 }
56 57
57 RenderFrameHostImpl::~RenderFrameHostImpl() { 58 RenderFrameHostImpl::~RenderFrameHostImpl() {
58 GetProcess()->RemoveRoute(routing_id_); 59 GetProcess()->RemoveRoute(routing_id_);
59 g_routing_id_frame_map.Get().erase( 60 g_routing_id_frame_map.Get().erase(
60 RenderFrameHostID(GetProcess()->GetID(), routing_id_)); 61 RenderFrameHostID(GetProcess()->GetID(), routing_id_));
61 if (delegate_) 62 if (delegate_)
62 delegate_->RenderFrameDeleted(this); 63 delegate_->RenderFrameDeleted(this);
64
65 // Notify the FrameTree that this RFH is going away, allowing it to shut down
66 // the corresponding RenderViewHost if it is no longer needed.
67 frame_tree_->UnregisterRenderFrameHost(this);
63 } 68 }
64 69
65 int RenderFrameHostImpl::GetRoutingID() { 70 int RenderFrameHostImpl::GetRoutingID() {
66 return routing_id_; 71 return routing_id_;
67 } 72 }
68 73
69 bool RenderFrameHostImpl::Send(IPC::Message* message) { 74 bool RenderFrameHostImpl::Send(IPC::Message* message) {
70 return GetProcess()->Send(message); 75 return GetProcess()->Send(message);
71 } 76 }
72 77
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 void RenderFrameHostImpl::OnDidStartProvisionalLoadForFrame( 124 void RenderFrameHostImpl::OnDidStartProvisionalLoadForFrame(
120 int64 frame_id, 125 int64 frame_id,
121 int64 parent_frame_id, 126 int64 parent_frame_id,
122 bool is_main_frame, 127 bool is_main_frame,
123 const GURL& url) { 128 const GURL& url) {
124 frame_tree_node_->navigator()->DidStartProvisionalLoad( 129 frame_tree_node_->navigator()->DidStartProvisionalLoad(
125 this, frame_id, parent_frame_id, is_main_frame, url); 130 this, frame_id, parent_frame_id, is_main_frame, url);
126 } 131 }
127 132
128 } // namespace content 133 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698