Issue 108483008: Make RenderFrameHostManager swap RenderFrameHosts, not RenderViewHosts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 108483008: Make RenderFrameHostManager swap RenderFrameHosts, not RenderViewHosts. (Closed)

Created:
7 years ago by Charlie Reis

Modified:
7 years ago

Reviewers:
jam, nasko

CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org, site-isolation-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Make RenderFrameHostManager swap RenderFrameHosts, not RenderViewHosts. We still only have a RFHM for the main frame and not subframes, unless the --site-per-process flag is passed. To external callers, RFHM is still effectively swapping RenderViewHosts. RenderFrameHosts now indirectly keep their RenderViewHosts alive. Second attempt, after fixing memory leak from http://crrev.com/241151. R=nasko@chromium.org TBR=jam@chromium.org BUG=314791 TEST=No visible behavior change. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241363

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix leak by removing unnecessary override #

Patch Set 3 : Rebase #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -6 lines)			Patch
	M	content/browser/web_contents/web_contents_impl_unittest.cc	View	1 2	1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Charlie Reis

Nasko: Can you take another look? This was reverted for a leak in the unit ...

7 years ago (2013-12-17 19:39:22 UTC) #1

Charlie Reis

Thanks! Since the chrome/ files haven't changed since last time, I'll mark jam@ as TBR ...

7 years ago (2013-12-17 20:54:48 UTC) #3

Charlie Reis

7 years ago (2013-12-17 21:29:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r241363 (presubmit successful).

Expand Messages | Collapse Messages