Source/core/editing/EditorCommand.cpp - Issue 108483002: Have Document::parseQualifiedName() deal with AtomicStrings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/EditorCommand.cpp

Issue 108483002: Have Document::parseQualifiedName() deal with AtomicStrings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/EditorCommand.cpp

diff --git a/Source/core/editing/EditorCommand.cpp b/Source/core/editing/EditorCommand.cpp

index 46ae8af3358cad6465d5ecc7da9b1723b1f17096..8c6291af1e013a5190945fdca9431aaa2e9e45aa 100644

--- a/Source/core/editing/EditorCommand.cpp

+++ b/Source/core/editing/EditorCommand.cpp

@@ -436,8 +436,8 @@ static bool executeFormatBlock(Frame& frame, Event*, EditorCommandSource, const

if (tagName[0] == '<' && tagName[tagName.length() - 1] == '>')

tagName = tagName.substring(1, tagName.length() - 2);

- String localName, prefix;

- if (!Document::parseQualifiedName(tagName, prefix, localName, IGNORE_EXCEPTION))

+ AtomicString localName, prefix;

+ if (!Document::parseQualifiedName(AtomicString(tagName), prefix, localName, IGNORE_EXCEPTION))

return false;

QualifiedName qualifiedTagName(prefix, localName, xhtmlNamespaceURI);

« no previous file with comments | « Source/core/dom/Element.cpp ('k') | Source/core/svg/animation/SVGSMILElement.cpp » ('j') | no next file with comments »