Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Side by Side Diff: Source/core/dom/Element.cpp

Issue 108483002: Have Document::parseQualifiedName() deal with AtomicStrings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/editing/EditorCommand.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
8 * (C) 2007 Eric Seidel (eric@webkit.org) 8 * (C) 2007 Eric Seidel (eric@webkit.org)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1982 matching lines...) Expand 10 before | Expand all | Expand 10 after
1993 return 0; 1993 return 0;
1994 } 1994 }
1995 1995
1996 RefPtr<Attr> guard(attr); 1996 RefPtr<Attr> guard(attr);
1997 detachAttrNodeAtIndex(attr, index); 1997 detachAttrNodeAtIndex(attr, index);
1998 return guard.release(); 1998 return guard.release();
1999 } 1999 }
2000 2000
2001 bool Element::parseAttributeName(QualifiedName& out, const AtomicString& namespa ceURI, const AtomicString& qualifiedName, ExceptionState& exceptionState) 2001 bool Element::parseAttributeName(QualifiedName& out, const AtomicString& namespa ceURI, const AtomicString& qualifiedName, ExceptionState& exceptionState)
2002 { 2002 {
2003 String prefix, localName; 2003 AtomicString prefix, localName;
2004 if (!Document::parseQualifiedName(qualifiedName, prefix, localName, exceptio nState)) 2004 if (!Document::parseQualifiedName(qualifiedName, prefix, localName, exceptio nState))
2005 return false; 2005 return false;
2006 ASSERT(!exceptionState.hadException()); 2006 ASSERT(!exceptionState.hadException());
2007 2007
2008 QualifiedName qName(prefix, localName, namespaceURI); 2008 QualifiedName qName(prefix, localName, namespaceURI);
2009 2009
2010 if (!Document::hasValidNamespaceForAttributes(qName)) { 2010 if (!Document::hasValidNamespaceForAttributes(qName)) {
2011 exceptionState.throwUninformativeAndGenericDOMException(NamespaceError); 2011 exceptionState.throwUninformativeAndGenericDOMException(NamespaceError);
2012 return false; 2012 return false;
2013 } 2013 }
(...skipping 1522 matching lines...) Expand 10 before | Expand all | Expand 10 after
3536 // Before doing so, we need to resolve issues in HTMLSelectElement::recalcLi stItems 3536 // Before doing so, we need to resolve issues in HTMLSelectElement::recalcLi stItems
3537 // and RenderMenuList::setText. See also https://bugs.webkit.org/show_bug.cg i?id=88405 3537 // and RenderMenuList::setText. See also https://bugs.webkit.org/show_bug.cg i?id=88405
3538 if (hasTagName(optionTag) || hasTagName(optgroupTag)) 3538 if (hasTagName(optionTag) || hasTagName(optgroupTag))
3539 return false; 3539 return false;
3540 if (FullscreenElementStack::isActiveFullScreenElement(this)) 3540 if (FullscreenElementStack::isActiveFullScreenElement(this))
3541 return false; 3541 return false;
3542 return true; 3542 return true;
3543 } 3543 }
3544 3544
3545 } // namespace WebCore 3545 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/dom/Document.cpp ('k') | Source/core/editing/EditorCommand.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698