Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: src/layout-descriptor-inl.h

Issue 1084793004: LayoutDescriptor should inherit from JSTypedArray (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/layout-descriptor.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_LAYOUT_DESCRIPTOR_INL_H_ 5 #ifndef V8_LAYOUT_DESCRIPTOR_INL_H_
6 #define V8_LAYOUT_DESCRIPTOR_INL_H_ 6 #define V8_LAYOUT_DESCRIPTOR_INL_H_
7 7
8 #include "src/layout-descriptor.h" 8 #include "src/layout-descriptor.h"
9 9
10 namespace v8 { 10 namespace v8 {
11 namespace internal { 11 namespace internal {
12 12
13 LayoutDescriptor* LayoutDescriptor::FromSmi(Smi* smi) { 13 LayoutDescriptor* LayoutDescriptor::FromSmi(Smi* smi) {
14 return LayoutDescriptor::cast(smi); 14 return LayoutDescriptor::cast(smi);
15 } 15 }
16 16
17 17
18 Handle<LayoutDescriptor> LayoutDescriptor::New(Isolate* isolate, int length) { 18 Handle<LayoutDescriptor> LayoutDescriptor::New(Isolate* isolate, int length) {
19 if (length <= kSmiValueSize) { 19 if (length <= kSmiValueSize) {
20 // The whole bit vector fits into a smi. 20 // The whole bit vector fits into a smi.
21 return handle(LayoutDescriptor::FromSmi(Smi::FromInt(0)), isolate); 21 return handle(LayoutDescriptor::FromSmi(Smi::FromInt(0)), isolate);
22 } 22 }
23 length = GetSlowModeBackingStoreLength(length); 23 length = GetSlowModeBackingStoreLength(length);
24 return Handle<LayoutDescriptor>::cast( 24 return Handle<LayoutDescriptor>::cast(
25 isolate->factory()->NewFixedTypedArray(length, kExternalUint32Array)); 25 isolate->factory()->NewJSTypedArray(UINT32_ELEMENTS, length));
26 } 26 }
27 27
28 28
29 bool LayoutDescriptor::InobjectUnboxedField(int inobject_properties, 29 bool LayoutDescriptor::InobjectUnboxedField(int inobject_properties,
30 PropertyDetails details) { 30 PropertyDetails details) {
31 if (details.type() != DATA || !details.representation().IsDouble()) { 31 if (details.type() != DATA || !details.representation().IsDouble()) {
32 return false; 32 return false;
33 } 33 }
34 // We care only about in-object properties. 34 // We care only about in-object properties.
35 return details.field_index() < inobject_properties; 35 return details.field_index() < inobject_properties;
36 } 36 }
37 37
38 38
39 LayoutDescriptor* LayoutDescriptor::FastPointerLayout() { 39 LayoutDescriptor* LayoutDescriptor::FastPointerLayout() {
40 return LayoutDescriptor::FromSmi(Smi::FromInt(0)); 40 return LayoutDescriptor::FromSmi(Smi::FromInt(0));
41 } 41 }
42 42
43 43
44 bool LayoutDescriptor::GetIndexes(int field_index, int* layout_word_index, 44 bool LayoutDescriptor::GetIndexes(int field_index, int* layout_word_index,
45 int* layout_bit_index) { 45 int* layout_bit_index) {
46 if (static_cast<unsigned>(field_index) >= static_cast<unsigned>(capacity())) { 46 if (static_cast<unsigned>(field_index) >= static_cast<unsigned>(capacity())) {
47 return false; 47 return false;
48 } 48 }
49 49
50 *layout_word_index = field_index / kNumberOfBits; 50 *layout_word_index = field_index / kNumberOfBits;
51 CHECK((!IsSmi() && (*layout_word_index < length())) || 51 CHECK((!IsSmi() && (*layout_word_index < Smi::cast(length())->value())) ||
52 (IsSmi() && (*layout_word_index < 1))); 52 (IsSmi() && (*layout_word_index < 1)));
53 53
54 *layout_bit_index = field_index % kNumberOfBits; 54 *layout_bit_index = field_index % kNumberOfBits;
55 return true; 55 return true;
56 } 56 }
57 57
58 58
59 LayoutDescriptor* LayoutDescriptor::SetTagged(int field_index, bool tagged) { 59 LayoutDescriptor* LayoutDescriptor::SetTagged(int field_index, bool tagged) {
60 int layout_word_index; 60 int layout_word_index;
61 int layout_bit_index; 61 int layout_bit_index;
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 116
117 bool LayoutDescriptor::IsFastPointerLayout(Object* layout_descriptor) { 117 bool LayoutDescriptor::IsFastPointerLayout(Object* layout_descriptor) {
118 return layout_descriptor == FastPointerLayout(); 118 return layout_descriptor == FastPointerLayout();
119 } 119 }
120 120
121 121
122 bool LayoutDescriptor::IsSlowLayout() { return !IsSmi(); } 122 bool LayoutDescriptor::IsSlowLayout() { return !IsSmi(); }
123 123
124 124
125 int LayoutDescriptor::capacity() { 125 int LayoutDescriptor::capacity() {
126 return IsSlowLayout() ? (length() * kNumberOfBits) : kSmiValueSize; 126 return IsSlowLayout() ? (Smi::cast(length())->value() * kNumberOfBits)
127 : kSmiValueSize;
127 } 128 }
128 129
129 130
131 uint32_t LayoutDescriptor::get_scalar(int index) {
132 DCHECK(IsSlowLayout());
133 return FixedTypedArray<Uint32ArrayTraits>::cast(elements())
134 ->get_scalar(index);
135 }
136
137
138 void LayoutDescriptor::set(int index, uint32_t value) {
139 DCHECK(IsSlowLayout());
140 FixedTypedArray<Uint32ArrayTraits>::cast(elements())->set(index, value);
141 }
142
143
130 LayoutDescriptor* LayoutDescriptor::cast_gc_safe(Object* object) { 144 LayoutDescriptor* LayoutDescriptor::cast_gc_safe(Object* object) {
131 if (object->IsSmi()) { 145 if (object->IsSmi()) {
132 // Fast mode layout descriptor. 146 // Fast mode layout descriptor.
133 return reinterpret_cast<LayoutDescriptor*>(object); 147 return reinterpret_cast<LayoutDescriptor*>(object);
134 } 148 }
135 149
136 // This is a mixed descriptor which is a fixed typed array. 150 // This is a mixed descriptor which is a fixed typed array.
137 MapWord map_word = reinterpret_cast<HeapObject*>(object)->map_word(); 151 MapWord map_word = reinterpret_cast<HeapObject*>(object)->map_word();
138 if (map_word.IsForwardingAddress()) { 152 if (map_word.IsForwardingAddress()) {
139 // Mark-compact has already moved layout descriptor. 153 // Mark-compact has already moved layout descriptor.
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
242 // Object headers do not contain non-tagged fields. 256 // Object headers do not contain non-tagged fields.
243 if (offset_in_bytes < header_size_) return true; 257 if (offset_in_bytes < header_size_) return true;
244 int field_index = (offset_in_bytes - header_size_) / kPointerSize; 258 int field_index = (offset_in_bytes - header_size_) / kPointerSize;
245 259
246 return layout_descriptor_->IsTagged(field_index); 260 return layout_descriptor_->IsTagged(field_index);
247 } 261 }
248 } 262 }
249 } // namespace v8::internal 263 } // namespace v8::internal
250 264
251 #endif // V8_LAYOUT_DESCRIPTOR_INL_H_ 265 #endif // V8_LAYOUT_DESCRIPTOR_INL_H_
OLDNEW
« no previous file with comments | « src/layout-descriptor.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698