Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 1084793004: LayoutDescriptor should inherit from JSTypedArray (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

LayoutDescriptor should inherit from JSTypedArray It can't just inherit from a FixedTypedArray-like type, as we soon assume that a FixedTypedArray-like type is always held by an ArrayBufferView-like type BUG=v8:3996 R=ishell@chromium.org,verwaest@chromium.org LOG=n Committed: https://crrev.com/6d79ceb2945bc23a33ac5c93285a2cab2ba2e126 Cr-Commit-Position: refs/heads/master@{#27964}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -20 lines) Patch
M src/factory.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/factory.cc View 4 chunks +87 lines, -2 lines 0 comments Download
M src/layout-descriptor.h View 2 chunks +4 lines, -1 line 0 comments Download
M src/layout-descriptor.cc View 3 chunks +17 lines, -6 lines 0 comments Download
M src/layout-descriptor-inl.h View 3 chunks +17 lines, -3 lines 0 comments Download
M src/objects-inl.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jochen (gone - plz use gerrit)
5 years, 8 months ago (2015-04-21 09:31:26 UTC) #1
Igor Sheludko
lgtm for now to unblock landing FixedTypedArray-ArrayBufferView relationship changes. The proper way would be to ...
5 years, 8 months ago (2015-04-21 12:50:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1084793004/1
5 years, 8 months ago (2015-04-21 12:59:58 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-21 13:07:36 UTC) #5
jochen (gone - plz use gerrit)
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1073053006/ by jochen@chromium.org. ...
5 years, 8 months ago (2015-04-21 14:02:50 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 04:09:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d79ceb2945bc23a33ac5c93285a2cab2ba2e126
Cr-Commit-Position: refs/heads/master@{#27964}

Powered by Google App Engine
This is Rietveld 408576698