use Analyzer's computed constants instead of pattern matching the annotation AST

lib/src/utils.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// Holds a couple utility functions used at various places in the system.
 library dev_compiler.src.utils;
 
 import 'dart:io';
 
 import 'package:path/path.dart' as path;
 import 'package:analyzer/src/generated/ast.dart'
     show
         ImportDirective,
         ExportDirective,
         PartDirective,
         CompilationUnit,
         Identifier,
         AnnotatedNode,
         AstNode,
         Expression,
         SimpleIdentifier;
 import 'package:analyzer/src/generated/engine.dart'
     show ParseDartTask, AnalysisContext;
 import 'package:analyzer/src/generated/source.dart' show Source;
 import 'package:analyzer/src/generated/element.dart';
+import 'package:analyzer/src/generated/constant.dart' show DartObjectImpl;
 import 'package:analyzer/analyzer.dart' show parseDirectives;
 import 'package:crypto/crypto.dart' show CryptoUtils, MD5;
 import 'package:source_span/source_span.dart';
 import 'package:yaml/yaml.dart';
 
 import 'codegen/js_names.dart' show invalidJSVariableName;
 
 bool isDartPrivateLibrary(LibraryElement library) {
   var uri = library.source.uri;
   if (uri.scheme != "dart") return false;
@@ skipping 301 matching lines @@
   // TODO(jmesserly): can we implement this without repeatedly reading pubspec?
   // It seems like we should know our package's root directory without needing
   // to search like this.
   var pubspec =
       loadYaml(new File(path.join(dir, 'pubspec.yaml')).readAsStringSync());
 
   // Ensure this is loaded from the dev_compiler package.
   if (pubspec['name'] != 'dev_compiler') return null;
   return path.join('dev_compiler', 'runtime', filename);
 }
+
+/// Given an annotated [node] and a [test] function, returns the first matching
+/// constant valued annotation.
+///
+/// For example if we had the ClassDeclaration node for `FontElement`:
+///
+///    @JsName('HTMLFontElement')
+///    @deprecated
+///    class FontElement { ... }
+///
+/// We could match `@deprecated` with a test function like:
+///
+///    (v) => v.type.name == 'Deprecated' && v.type.element.library.isDartCore
+///
+DartObjectImpl getAnnotationValue(
+    AnnotatedNode node, bool test(DartObjectImpl value)) {
+  for (var metadata in node.metadata) {
+    ElementAnnotationImpl element = metadata.elementAnnotation;
+    if (element == null) continue;
+
+    var evalResult = element.evaluationResult;
+    if (evalResult == null) continue;
+
+    var value = evalResult.value;
+    if (value != null && test(value)) return value;
+  }
+  return null;
+}
+
+/// Given a constant [value] and a [fieldName], returns the string value of
+/// that field.
+///
+/// If the field is missing or is not a string, returns null.
+String getStringConstantField(DartObjectImpl value, String fieldName) {
+  if (value == null) return null;
+  var fieldValue = value.fields[fieldName];
+  if (fieldValue == null) return null;
+  var result = fieldValue.value;
+  return result is String ? result : null;

[Paul Berry, 2015/04/14 17:51:27]

Not sure if it matters, but the analyzer stores both strings and symbols using
String internally.  So if you implement it this way, getStringConstantField will
interpret @JsName(@HTMLFontElement) as equivalent to @JsName('HTMLFontElement').

If you care about this and want to avoid it, consider checking fieldValue.type,
e.g.:

Element fieldClass = fieldValue.type.element;
if (fieldClass == null || !fieldClass.library.isDartCore || fieldClass.name !=
'String') return null;

Or, if you have easy access to the type provider, you can simply do:

if (fieldValue.type != typeProvider.stringType) return null;

[Jennifer Messerly, 2015/04/15 00:21:26]

ah good catch! I'll update it to fix that.

+}