Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Side by Side Diff: pkg/compiler/lib/src/js_backend/codegen/js_tree_builder.dart

Issue 1084783004: tree-ir: Treat getInterceptor and identical as effectively constant. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Update test cases Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library js_tree_ir_builder; 5 library js_tree_ir_builder;
6 6
7 import '../../tree_ir/tree_ir_builder.dart' show Builder; 7 import '../../tree_ir/tree_ir_builder.dart' show Builder;
8 import 'glue.dart' show Glue; 8 import 'glue.dart' show Glue;
9 import '../../dart2jslib.dart' show Selector, InternalErrorFunction; 9 import '../../dart2jslib.dart' show Selector, InternalErrorFunction;
10 import '../../elements/elements.dart'; 10 import '../../elements/elements.dart';
(...skipping 19 matching lines...) Expand all
30 30
31 Selector get identicalSelector { 31 Selector get identicalSelector {
32 return new Selector.call('identical', null, 2); 32 return new Selector.call('identical', null, 2);
33 } 33 }
34 34
35 Expression visitIdentical(cps_ir.Identical node) { 35 Expression visitIdentical(cps_ir.Identical node) {
36 return new InvokeStatic( 36 return new InvokeStatic(
37 identicalFunction, 37 identicalFunction,
38 identicalSelector, 38 identicalSelector,
39 <Expression>[getVariableUse(node.left), 39 <Expression>[getVariableUse(node.left),
40 getVariableUse(node.right)]); 40 getVariableUse(node.right)])..isEffectivelyConstant = true;
41 } 41 }
42 42
43 Expression visitInterceptor(cps_ir.Interceptor node) { 43 Expression visitInterceptor(cps_ir.Interceptor node) {
44 Element getInterceptor = _glue.getInterceptorMethod; 44 Element getInterceptor = _glue.getInterceptorMethod;
45 String name = _glue.getInterceptorName(node.interceptedClasses); 45 String name = _glue.getInterceptorName(node.interceptedClasses);
46 Selector selector = new Selector.call(name, null, 1); 46 Selector selector = new Selector.call(name, null, 1);
47 _glue.registerUseInterceptorInCodegen(); 47 _glue.registerUseInterceptorInCodegen();
48 return new InvokeStatic( 48 return new InvokeStatic(
49 getInterceptor, 49 getInterceptor,
50 selector, 50 selector,
51 <Expression>[getVariableUse(node.input)]); 51 <Expression>[getVariableUse(node.input)])..isEffectivelyConstant = true;
52 } 52 }
53 53
54 Expression visitGetField(cps_ir.GetField node) { 54 Expression visitGetField(cps_ir.GetField node) {
55 return new GetField(getVariableUse(node.object), node.field); 55 return new GetField(getVariableUse(node.object), node.field);
56 } 56 }
57 57
58 Statement visitSetField(cps_ir.SetField node) { 58 Statement visitSetField(cps_ir.SetField node) {
59 SetField setField = 59 SetField setField =
60 new SetField(getVariableUse(node.object), 60 new SetField(getVariableUse(node.object),
61 node.field, 61 node.field,
62 getVariableUse(node.value)); 62 getVariableUse(node.value));
63 return new ExpressionStatement(setField, visit(node.body)); 63 return new ExpressionStatement(setField, visit(node.body));
64 } 64 }
65 65
66 Expression visitCreateBox(cps_ir.CreateBox node) { 66 Expression visitCreateBox(cps_ir.CreateBox node) {
67 return new CreateBox(); 67 return new CreateBox();
68 } 68 }
69 69
70 Expression visitCreateInstance(cps_ir.CreateInstance node) { 70 Expression visitCreateInstance(cps_ir.CreateInstance node) {
71 return new CreateInstance( 71 return new CreateInstance(
72 node.classElement, 72 node.classElement,
73 node.arguments.map(getVariableUse).toList(growable: false), 73 node.arguments.map(getVariableUse).toList(growable: false),
74 node.typeInformation.map(getVariableUse).toList(growable: false)); 74 node.typeInformation.map(getVariableUse).toList(growable: false));
75 } 75 }
76 } 76 }
OLDNEW
« no previous file with comments | « no previous file | pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698