Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1084763002: Remove operator delete on VS2015 to avoid compiler bug (Closed)

Created:
5 years, 8 months ago by scottmg
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove operator delete on VS2015 to avoid compiler bug LOG=N R=jochen@chromium.org BUG=chromium:440500 Committed: https://crrev.com/961e61b012b28cf521809c01894b81d1282cbc2f Cr-Commit-Position: refs/heads/master@{#27853}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M src/deoptimizer.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
scottmg
5 years, 8 months ago (2015-04-14 20:15:21 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 8 months ago (2015-04-15 15:26:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1084763002/1
5 years, 8 months ago (2015-04-15 15:57:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/2021)
5 years, 8 months ago (2015-04-15 16:05:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1084763002/1
5 years, 8 months ago (2015-04-15 16:13:21 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-15 16:23:35 UTC) #10
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 16:23:46 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/961e61b012b28cf521809c01894b81d1282cbc2f
Cr-Commit-Position: refs/heads/master@{#27853}

Powered by Google App Engine
This is Rietveld 408576698