Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1084753002: Add some configure/CMake options for enabling/disabling Subzero targets. (Closed)

Created:
5 years, 8 months ago by jvoung (off chromium)
Modified:
5 years, 8 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-llvm.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add some configure/CMake options for enabling/disabling Subzero targets. Mirrors the LLVM_TARGETS_TO_BUILD, but kept separate since (a) the spellings are different (b) we may keep X8632 separate from X8664 unlike LLVM This setups up an xmacro file to enumerate the enabled targets. NaCl change: https://codereview.chromium.org/1082953002/ Subzero change: https://codereview.chromium.org/1075363002/ This change has to be atomic w/ the NaCl change since the default is "none" which blows up. An alternative may be to move the header to Subzero, and "configure" stuff via -D in the CXXFLAGS, filling in the .def file that way if possible. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4076 R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=8284e69d05eaa434959cfaf4fe16877ba0395cff

Patch Set 1 #

Patch Set 2 : remember the header #

Total comments: 2

Patch Set 3 : line up better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -12 lines) Patch
M CMakeLists.txt View 3 chunks +16 lines, -0 lines 0 comments Download
M Makefile View 1 chunk +1 line, -0 lines 0 comments Download
M autoconf/configure.ac View 1 2 3 chunks +29 lines, -1 line 0 comments Download
M configure View 1 2 8 chunks +43 lines, -4 lines 0 comments Download
A + include/llvm/Config/SZTargets.def.in View 1 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jvoung (off chromium)
Thought I would throw this out there for some opinions. I'll give the CXXFLAG option ...
5 years, 8 months ago (2015-04-14 00:29:13 UTC) #3
Jim Stichnoth
Half-science-dog lgtm. https://codereview.chromium.org/1084753002/diff/20001/autoconf/configure.ac File autoconf/configure.ac (right): https://codereview.chromium.org/1084753002/diff/20001/autoconf/configure.ac#newcode1070 autoconf/configure.ac:1070: ARM32) SUBZERO_TARGETS_TO_BUILD="ARM32 $SUBZERO_TARGETS_TO_BUILD" ;; Line these up ...
5 years, 8 months ago (2015-04-17 16:54:36 UTC) #4
jvoung (off chromium)
Thanks -- half-science-dog CL ;-) https://codereview.chromium.org/1084753002/diff/20001/autoconf/configure.ac File autoconf/configure.ac (right): https://codereview.chromium.org/1084753002/diff/20001/autoconf/configure.ac#newcode1070 autoconf/configure.ac:1070: ARM32) SUBZERO_TARGETS_TO_BUILD="ARM32 $SUBZERO_TARGETS_TO_BUILD" ;; ...
5 years, 8 months ago (2015-04-17 21:07:01 UTC) #5
jvoung (off chromium)
5 years, 8 months ago (2015-04-21 21:05:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
8284e69d05eaa434959cfaf4fe16877ba0395cff (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698