Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1084613006: Fix all remaining instances of FX_NEW. (Closed)

Created:
5 years, 8 months ago by Tom Sepez
Modified:
5 years, 8 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : std::min #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -149 lines) Patch
M core/include/fpdfapi/fpdf_objects.h View 9 chunks +15 lines, -15 lines 0 comments Download
M core/include/fxcrt/fx_memory.h View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_arabic.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fx_extension.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M core/src/fxcrt/fxcrt_platforms.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fxcrt_posix.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxcrt/fxcrt_windows.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/src/fxge/agg/agg23/fx_agg_driver.cpp View 7 chunks +9 lines, -30 lines 0 comments Download
M core/src/fxge/android/fpf_skiafontmgr.cpp View 2 chunks +6 lines, -13 lines 0 comments Download
M core/src/fxge/android/fpf_skiamodule.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M core/src/fxge/android/fx_android_imp.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M core/src/reflow/autoreflow.cpp View 4 chunks +4 lines, -8 lines 0 comments Download
M core/src/reflow/layoutprocessor_reflow.cpp View 4 chunks +5 lines, -14 lines 0 comments Download
M core/src/reflow/layoutprovider_taggedpdf.cpp View 3 chunks +3 lines, -14 lines 0 comments Download
M core/src/reflow/reflowedpage.cpp View 4 chunks +7 lines, -12 lines 0 comments Download
M core/src/reflow/reflowedtextpage.cpp View 1 2 chunks +6 lines, -13 lines 0 comments Download
M core/src/reflow/reflowengine.cpp View 3 chunks +3 lines, -7 lines 0 comments Download
M fpdfsdk/src/fpdf_flatten.cpp View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Tom Sepez
Lei, last one.
5 years, 8 months ago (2015-04-17 21:12:44 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1084613006/diff/1/core/src/reflow/reflowedtextpage.cpp File core/src/reflow/reflowedtextpage.cpp (right): https://codereview.chromium.org/1084613006/diff/1/core/src/reflow/reflowedtextpage.cpp#newcode35 core/src/reflow/reflowedtextpage.cpp:35: m_pDataList = new CRF_CharDataPtrArray(count < 500 ? count ...
5 years, 8 months ago (2015-04-17 21:58:53 UTC) #3
Tom Sepez
https://codereview.chromium.org/1084613006/diff/1/core/src/reflow/reflowedtextpage.cpp File core/src/reflow/reflowedtextpage.cpp (right): https://codereview.chromium.org/1084613006/diff/1/core/src/reflow/reflowedtextpage.cpp#newcode35 core/src/reflow/reflowedtextpage.cpp:35: m_pDataList = new CRF_CharDataPtrArray(count < 500 ? count : ...
5 years, 8 months ago (2015-04-17 22:14:45 UTC) #4
Tom Sepez
5 years, 8 months ago (2015-04-17 22:15:14 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
4cb07c9c9cd5761ce3179d3d7254c1cf0efeafa5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698