Issue 1084583003: PPC: Fix NaN Canonicalization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1084583003: PPC: Fix NaN Canonicalization. (Closed)

Created:
5 years, 8 months ago by MTBrandyberry

Modified:
5 years, 8 months ago

Reviewers:
michael_dawson

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

PPC: Fix NaN Canonicalization. Use fsub rather than fadd to avoid stripping the sign from minus zero. Fixes mjsunit/result-table-min and mjsunit/result-table-max test failures. R=michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/c7f40ce7387b5b8b52bdc47a1ad73496b1c2d032 Cr-Commit-Position: refs/heads/master@{#27794}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/ppc/macro-assembler-ppc.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (1 generated)

MTBrandyberry

Fixes mjsunit/result-table-min and mjsunit/result-table-max test failures.

5 years, 8 months ago (2015-04-13 15:24:24 UTC) #1

michael_dawson

On 2015/04/13 15:24:24, mtbrandyberry wrote: > Fixes mjsunit/result-table-min and mjsunit/result-table-max test failures. lgtm.

5 years, 8 months ago (2015-04-13 15:25:44 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1084583003/1

5 years, 8 months ago (2015-04-13 15:26:06 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-04-13 16:24:46 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c7f40ce7387b5b8b52bdc47a1ad73496b1c2d032
Cr-Commit-Position: refs/heads/master@{#27794}