Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: site/dev/sheriffing/index.md

Issue 1084583002: Update rebaselining process to be less Florin intensive (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Update Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 Tree Sheriffs Documentation 1 Tree Sheriffs Documentation
2 =========================== 2 ===========================
3 3
4 ### Contents ### 4 ### Contents ###
5 5
6 * [What does a sheriff do?](#what_is_a_sheriff) 6 * [What does a sheriff do?](#what_is_a_sheriff)
7 + [Skia tree](#skia_tree) 7 + [Skia tree](#skia_tree)
8 + [DEPS rolls](#deps_rolls) 8 + [DEPS rolls](#deps_rolls)
9 + [Gold and Perf](#gold_and_perf) 9 + [Gold and Perf](#gold_and_perf)
10 + [Documentation](#sheriff_doc) 10 + [Documentation](#sheriff_doc)
(...skipping 112 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 * goto [crbug.com](https://crbug.com) 123 * goto [crbug.com](https://crbug.com)
124 * Make sure you’re logged in with your Chromium credentials 124 * Make sure you’re logged in with your Chromium credentials
125 * Click “New Issue” 125 * Click “New Issue”
126 * Summary: “Skia image rebaseline” 126 * Summary: “Skia image rebaseline”
127 * Description: 127 * Description:
128 * DEPS roll #, 128 * DEPS roll #,
129 * Helpful message about what went wrong (e.g., “Changes to how lighting is scaled in Skia r#### changed the following images:”) 129 * Helpful message about what went wrong (e.g., “Changes to how lighting is scaled in Skia r#### changed the following images:”)
130 * Layout tests effected 130 * Layout tests effected
131 * You should copy the list of affected from stdio of the failing bot 131 * You should copy the list of affected from stdio of the failing bot
132 * Status: Assigned 132 * Status: Assigned
133 * Owner: fmalita@ 133 * Owner: yourself
134 * cc: reed@, bsalomon@, robertphillips@ & developer responsible for changes 134 * cc: reed@, bsalomon@, robertphillips@ & developer responsible for changes
135 * Labels: OS-All & Cr-Blink-LayoutTests 135 * Labels: OS-All & Cr-Blink-LayoutTests
136 * If it is filter related, cc senorblanco@ 136 * If it is filter related, cc senorblanco@
137 137
138 * Edit [skia/skia_test_expectations.txt](https://chromium.googlesource.com/chrom ium/src/+/master/skia/skia_test_expectations.txt) 138 * (Dispreferred but faster) Edit [skia/skia_test_expectations.txt](https://chrom ium.googlesource.com/chromium/src/+/master/skia/skia_test_expectations.txt)
139 * Add # comment about what has changed (I usually paraphrase the crbug text) 139 * Add # comment about what has changed (I usually paraphrase the crbug text)
140 * Add line(s) like after the comment: 140 * Add line(s) like the following after the comment:
141 * crbug.com/<bug#youjustcreated> foo/bar/test-name.html [ ImageOnlyFailure ] 141 * crbug.com/<bug#youjustcreated> foo/bar/test-name.html [ ImageOnlyFailure ]
142 * Note: this change is usually done in the DEPS roll patch itself
142 143
143 * Commit the changes and fire off new try bots (you usually only need to fire of f the layout bots) 144 * (Preferred but slower) Make a separate Blink patch by editing LayoutTests/Test Expectations
jcgregorio 2015/04/13 14:14:07 Maybe move the Preferred option to appear before t
145 * Add # comment about what has changed (I usually paraphrase the crbug text)
146 * Add line(s) like the following after the comment:
147 * crbug.com/<bug#youjustcreated> foo/bar/test-name.html [ NeedsManualRebas eline ]
148 * Commit the patch you created and wait until it lands and rolls into Chrome
149
150 * Retry the DEPS roll (for the 1st/dispreferred option this usually means just r etrying the layout bots)
151 * Make a Blink patch by editing LayoutTests/TestExpectations
152 * Add # comment about what has changed
153 * Add line(s) like the following after the comment:
154 * crbug.com/<bug#youjustcreated> foo/bar/test-name.html [ NeedsRebaseline ]
155 * (if you took the second option above you can just edit the existing li ne(s))
156
157 * If you took the first/dispreferred option above:
158 * Wait for the Blink patch to roll into Chrome
159 * Create a Chrome patch that removes your suppressions from skia/skia_test_exp ectations.txt
160
161
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698