Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 1084533004: [Android] Disable the refresh effect for fullscreen HTML5 scenarios (Closed)

Created:
5 years, 7 months ago by jdduke (slow)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Disable the refresh effect for fullscreen HTML5 scenarios This regressed recently with the transition to the View-based pull-to-refresh implementation. Restore the proper behavior which is to suppress pull-to-refresh for fullscreen HTML5 scenarios. BUG=435732 Committed: https://crrev.com/b1c26a82bb8daf52443ec586abe91f7bf54dbf98 Cr-Commit-Position: refs/heads/master@{#327519}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M content/browser/android/overscroll_controller_android.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/android/overscroll_controller_android.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jdduke (slow)
aurimas@: PTAL, thanks.
5 years, 7 months ago (2015-04-29 16:18:51 UTC) #2
aurimas (slooooooooow)
lgtm
5 years, 7 months ago (2015-04-29 16:48:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1084533004/1
5 years, 7 months ago (2015-04-29 16:57:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 17:42:31 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 17:43:15 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1c26a82bb8daf52443ec586abe91f7bf54dbf98
Cr-Commit-Position: refs/heads/master@{#327519}

Powered by Google App Engine
This is Rietveld 408576698