Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: net/http/http_cache_unittest.cc

Issue 1084533002: Rename NetLogLogger and CapturingNetLog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_cache_unittest.cc
diff --git a/net/http/http_cache_unittest.cc b/net/http/http_cache_unittest.cc
index d62901610a28a395e427eae1c88136580b01ddea..0df6da93ded2f885744dba7be8650e3442dbdebb 100644
--- a/net/http/http_cache_unittest.cc
+++ b/net/http/http_cache_unittest.cc
@@ -534,7 +534,7 @@ class FakeWebSocketHandshakeStreamCreateHelper
// Returns true if |entry| is not one of the log types paid attention to in this
// test. Note that TYPE_HTTP_CACHE_WRITE_INFO and TYPE_HTTP_CACHE_*_DATA are
// ignored.
-bool ShouldIgnoreLogEntry(const net::CapturingNetLog::CapturedEntry& entry) {
+bool ShouldIgnoreLogEntry(const net::TestNetLog::CapturedEntry& entry) {
switch (entry.type) {
case net::NetLog::TYPE_HTTP_CACHE_GET_BACKEND:
case net::NetLog::TYPE_HTTP_CACHE_OPEN_ENTRY:
@@ -550,7 +550,7 @@ bool ShouldIgnoreLogEntry(const net::CapturingNetLog::CapturedEntry& entry) {
// Modifies |entries| to only include log entries created by the cache layer and
// asserted on in these tests.
-void FilterLogEntries(net::CapturingNetLog::CapturedEntryList* entries) {
+void FilterLogEntries(net::TestNetLog::CapturedEntryList* entries) {
entries->erase(std::remove_if(entries->begin(), entries->end(),
&ShouldIgnoreLogEntry),
entries->end());
@@ -558,7 +558,7 @@ void FilterLogEntries(net::CapturingNetLog::CapturedEntryList* entries) {
bool LogContainsEventType(const net::CapturingBoundNetLog& log,
net::NetLog::EventType expected) {
- net::CapturingNetLog::CapturedEntryList entries;
+ net::TestNetLog::CapturedEntryList entries;
log.GetEntries(&entries);
for (size_t i = 0; i < entries.size(); i++) {
if (entries[i].type == expected)
@@ -620,7 +620,7 @@ TEST(HttpCache, SimpleGETNoDiskCache) {
// Check that the NetLog was filled as expected.
// (We attempted to both Open and Create entries, but both failed).
- net::CapturingNetLog::CapturedEntryList entries;
+ net::TestNetLog::CapturedEntryList entries;
log.GetEntries(&entries);
FilterLogEntries(&entries);
@@ -785,7 +785,7 @@ TEST(HttpCache, SimpleGET_LoadOnlyFromCache_Hit) {
log.bound(), &load_timing_info);
// Check that the NetLog was filled as expected.
- net::CapturingNetLog::CapturedEntryList entries;
+ net::TestNetLog::CapturedEntryList entries;
log.GetEntries(&entries);
FilterLogEntries(&entries);
@@ -1143,7 +1143,7 @@ TEST(HttpCache, SimpleGET_LoadBypassCache) {
&load_timing_info);
// Check that the NetLog was filled as expected.
- net::CapturingNetLog::CapturedEntryList entries;
+ net::TestNetLog::CapturedEntryList entries;
log.GetEntries(&entries);
FilterLogEntries(&entries);

Powered by Google App Engine
This is Rietveld 408576698