Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 1084513002: Expose ArrayBufferView::HasBuffer (Closed)

Created:
5 years, 8 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 8 months ago
CC:
v8-dev, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Expose ArrayBufferView::HasBuffer This allows the embedder to decide whether it's worthwhile to copy the contents to avoid materializing a buffer. BUG=v8:3996 R=dslomov@chromium.org,kbr@chromium.org LOG=y Committed: https://crrev.com/ada32ae63651f544801647b7a6fe16f0f6146996 Cr-Commit-Position: refs/heads/master@{#27782}

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -13 lines) Patch
M include/v8.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/api.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M test/cctest/test-typedarrays.cc View 1 chunk +2 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jochen (gone - plz use gerrit)
5 years, 8 months ago (2015-04-13 06:56:33 UTC) #1
Dmitry Lomov (no reviews)
lgtm % comment https://codereview.chromium.org/1084513002/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/1084513002/diff/1/include/v8.h#newcode3515 include/v8.h:3515: * Returns true if ArrayBufferView::Buffer() is ...
5 years, 8 months ago (2015-04-13 08:46:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1084513002/20001
5 years, 8 months ago (2015-04-13 11:02:59 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-13 11:28:07 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-13 11:28:20 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ada32ae63651f544801647b7a6fe16f0f6146996
Cr-Commit-Position: refs/heads/master@{#27782}

Powered by Google App Engine
This is Rietveld 408576698