Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1084473005: Certificate Transparency: Adding Izenpe's log. (Closed)

Created:
5 years, 8 months ago by Eran Messeri
Modified:
5 years, 8 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Certificate Transparency: Adding Izenpe's log. BUG=431700 Committed: https://crrev.com/0ee3daafefb92eb16c27c4e48f700c3a18b73cf2 Cr-Commit-Position: refs/heads/master@{#326301}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Matching net style #

Patch Set 3 : Correcting log name. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -42 lines) Patch
M net/cert/ct_known_logs_static.h View 1 2 1 chunk +43 lines, -42 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Eran Messeri
5 years, 8 months ago (2015-04-22 12:32:31 UTC) #2
Ryan Sleevi
LGTM with a take-or-pick nit. https://codereview.chromium.org/1084473005/diff/1/net/cert/ct_known_logs_static.h File net/cert/ct_known_logs_static.h (right): https://codereview.chromium.org/1084473005/diff/1/net/cert/ct_known_logs_static.h#newcode65 net/cert/ct_known_logs_static.h:65: const size_t kNumKnownCTLogs = ...
5 years, 8 months ago (2015-04-22 12:34:38 UTC) #3
Eran Messeri
Note two follow-up patchsets with updated formatting (to match net's current style) and slightly changing ...
5 years, 8 months ago (2015-04-22 14:24:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1084473005/40001
5 years, 8 months ago (2015-04-22 14:24:38 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-22 15:30:42 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 15:31:39 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0ee3daafefb92eb16c27c4e48f700c3a18b73cf2
Cr-Commit-Position: refs/heads/master@{#326301}

Powered by Google App Engine
This is Rietveld 408576698