Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 1084463003: Start building core_services.mojo. (Closed)

Created:
5 years, 8 months ago by Elliot Glaysher
Modified:
5 years, 8 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, dcheng, abarth-chromium, Aaron Boodman, yzshen+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Start building core_services.mojo. Instead of having an application for clipboard.mojo, a view_manager.mojo, et all, we instead will have one core_services application which provides implementations of all the services compiled into one physical file so we don't have to pay the cost of //base/ in each application. For now, this just moves clipboard.mojo into core_services. BUG=477435 R=sky@chromium.org TBR=ben@chromium.org Committed: https://crrev.com/8a134821836eb6bf6750f9ee31c32fee4e1d3b06 Cr-Commit-Position: refs/heads/master@{#327077}

Patch Set 1 #

Patch Set 2 : Commentastic. #

Patch Set 3 : Speculative fix for linux gn bot. #

Patch Set 4 : And I didn't even use it. ggrrrrrr. #

Patch Set 5 : Next attempt at fixing build. #

Patch Set 6 : Try # whatever. #

Patch Set 7 : Remove core services from higher level build.gn file. #

Patch Set 8 : Don't move clipboard around. #

Patch Set 9 : Fix deps; reupload to see if android failures are tree related. #

Patch Set 10 : Rebase to ToT #

Patch Set 11 : Add OWNERS files for directories. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -7 lines) Patch
D components/clipboard/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +11 lines, -2 lines 0 comments Download
A + components/clipboard/OWNERS View 1 2 3 4 5 6 7 8 9 10 0 chunks +-1 lines, --1 lines 0 comments Download
A components/core_services/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +26 lines, -0 lines 0 comments Download
A + components/core_services/DEPS View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
A + components/core_services/OWNERS View 1 2 3 4 5 6 7 8 9 10 1 chunk +1 line, -0 lines 0 comments Download
A components/core_services/core_services_application_delegate.h View 1 chunk +47 lines, -0 lines 0 comments Download
A components/core_services/core_services_application_delegate.cc View 1 2 3 4 5 6 7 1 chunk +57 lines, -0 lines 0 comments Download
A + components/core_services/main.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/html_viewer/blink_platform_impl.cc View 2 chunks +4 lines, -1 line 0 comments Download
M mojo/services/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Elliot Glaysher
OK. Finally got this to compile. This here is the minimal skeleton of the core_services.mojo ...
5 years, 8 months ago (2015-04-24 20:26:28 UTC) #2
Elliot Glaysher
ptal, I talked to Ben and he agreed that files shouldn't be moved.
5 years, 8 months ago (2015-04-27 17:17:50 UTC) #3
sky
LGTM
5 years, 8 months ago (2015-04-27 17:33:58 UTC) #4
Elliot Glaysher
+ben tbr for deps on mojo from a new directory
5 years, 8 months ago (2015-04-27 17:50:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1084463003/200001
5 years, 8 months ago (2015-04-27 17:52:48 UTC) #9
Ben Goodger (Google)
lgtm
5 years, 8 months ago (2015-04-27 18:00:25 UTC) #10
commit-bot: I haz the power
Committed patchset #11 (id:200001)
5 years, 8 months ago (2015-04-27 18:27:15 UTC) #11
commit-bot: I haz the power
5 years, 8 months ago (2015-04-27 18:28:04 UTC) #12
Message was sent while issue was closed.
Patchset 11 (id:??) landed as
https://crrev.com/8a134821836eb6bf6750f9ee31c32fee4e1d3b06
Cr-Commit-Position: refs/heads/master@{#327077}

Powered by Google App Engine
This is Rietveld 408576698