Ensure that Code objects' kind specific flags are initialized properly.

Ensure that Code objects' kind specific flags are initialized properly.

Also, have the stub cache set a valid MajorKey on stubs it creates.
Getting weird random bits frightens and confuses the poor simple type feedback oracle.

R=hpayer@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=18309

[Jakob Kummerow, 2013-12-13 09:55:21]

PTAL.

[Hannes Payer (out of office), 2013-12-13 10:03:25]

LGTM, minor nits

https://codereview.chromium.org/108443004/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/108443004/diff/1/src/objects-inl.h#newcode3921
src/objects-inl.h:3921: }
Can we have 2 newlines here?

https://codereview.chromium.org/108443004/diff/1/src/stub-cache.cc
File src/stub-cache.cc (right):

https://codereview.chromium.org/108443004/diff/1/src/stub-cache.cc#newcode1103
src/stub-cache.cc:1103: if (code->has_major_key()) {
I think it would make sense to set the major key in CreateCode.

[Jakob Kummerow, 2013-12-13 10:14:25]

https://codereview.chromium.org/108443004/diff/1/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/108443004/diff/1/src/objects-inl.h#newcode3921
src/objects-inl.h:3921: }
On 2013/12/13 10:03:26, Hannes Payer wrote:
> Can we have 2 newlines here?

Sure.

https://codereview.chromium.org/108443004/diff/1/src/stub-cache.cc
File src/stub-cache.cc (right):

https://codereview.chromium.org/108443004/diff/1/src/stub-cache.cc#newcode1103
src/stub-cache.cc:1103: if (code->has_major_key()) {
On 2013/12/13 10:03:26, Hannes Payer wrote:
> I think it would make sense to set the major key in CreateCode.

I disagree. CreateCode() sets it to UninitializedMajorKey. Everything else is at
the caller's discretion.

[Jakob Kummerow, 2013-12-13 10:27:29]

Committed patchset #2 manually as r18309.