Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1467)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/MicrophoneCaptureInfo.java

Issue 1084423002: Split Camera and Mic into two permissions on the Site Details page (under Site Settings). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Polish Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/website/MicrophoneCaptureInfo.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/MidiInfo.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/MicrophoneCaptureInfo.java
similarity index 65%
copy from chrome/android/java/src/org/chromium/chrome/browser/preferences/website/MidiInfo.java
copy to chrome/android/java/src/org/chromium/chrome/browser/preferences/website/MicrophoneCaptureInfo.java
index fa68b4b57c37a46cf6180b9438f10c83ed2e05db..473bd1cec851747f389c52bdcba458eba64995c7 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/MidiInfo.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/MicrophoneCaptureInfo.java
@@ -5,21 +5,21 @@
package org.chromium.chrome.browser.preferences.website;
/**
- * Midi information for a given origin.
+ * TODOf doc
newt (away) 2015/04/22 17:35:55 TODO
Finnur 2015/04/24 13:51:59 Done.
*/
-public class MidiInfo extends PermissionInfo {
- public MidiInfo(String origin, String embedder) {
+public class MicrophoneCaptureInfo extends PermissionInfo {
newt (away) 2015/04/22 17:35:55 "MicrophoneInfo"?
Finnur 2015/04/24 13:51:59 Done.
+ public MicrophoneCaptureInfo(String origin, String embedder) {
super(origin, embedder);
}
protected int getNativePreferenceValue(String origin, String embedder) {
- return WebsitePreferenceBridge.nativeGetMidiSettingForOrigin(
+ return WebsitePreferenceBridge.nativeGetVoiceCaptureSettingForOrigin(
newt (away) 2015/04/22 17:35:55 s/VoiceCapture/Microphone
Finnur 2015/04/24 13:51:59 Done.
origin, embedder);
}
protected void setNativePreferenceValue(
String origin, String embedder, int value) {
- WebsitePreferenceBridge.nativeSetMidiSettingForOrigin(
+ WebsitePreferenceBridge.nativeSetVoiceCaptureSettingForOrigin(
origin, embedder, value);
}
}

Powered by Google App Engine
This is Rietveld 408576698