chrome/android/java/res/xml/single_website_preferences.xml - Issue 1084423002: Split Camera and Mic into two permissions on the Site Details page (under Site Settings).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/res/xml/single_website_preferences.xml

Issue 1084423002: Split Camera and Mic into two permissions on the Site Details page (under Site Settings). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Polish Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/xml/single_website_preferences.xml

diff --git a/chrome/android/java/res/xml/single_website_preferences.xml b/chrome/android/java/res/xml/single_website_preferences.xml

index 503ca43200702392ee4e5f4d27fcc584f461bb26..289dd9027024b5a24b6f544fe280af469c171350 100644

--- a/chrome/android/java/res/xml/single_website_preferences.xml

+++ b/chrome/android/java/res/xml/single_website_preferences.xml

@@ -25,7 +25,9 @@

<org.chromium.chrome.browser.preferences.ChromeBaseListPreference

android:key="cookies_permission_list" />

<org.chromium.chrome.browser.preferences.ChromeBaseListPreference

- android:key="voice_and_video_capture_permission_list" />

+ android:key="video_capture_permission_list" />

newt (away) 2015/04/16 17:11:20 nit: let's use consistent naming for these permiss

Finnur 2015/04/22 16:01:38 Yeah, I agree. In addition to being consistent, I

+ <org.chromium.chrome.browser.preferences.ChromeBaseListPreference

+ android:key="voice_capture_permission_list" />

<org.chromium.chrome.browser.preferences.ChromeBaseListPreference

android:key="popup_permission_list" />

<org.chromium.chrome.browser.preferences.ChromeBaseListPreference