Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Unified Diff: chrome/browser/android/preferences/website_preference_bridge.cc

Issue 1084423002: Split Camera and Mic into two permissions on the Site Details page (under Site Settings). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix test Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/preferences/pref_service_bridge.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/preferences/website_preference_bridge.cc
diff --git a/chrome/browser/android/preferences/website_preference_bridge.cc b/chrome/browser/android/preferences/website_preference_bridge.cc
index a82ee7513e878fd26f14a3488a0f5a7b5ec3a0a8..feba4057ff775d92a15541ca7b6cda225878a0ac 100644
--- a/chrome/browser/android/preferences/website_preference_bridge.cc
+++ b/chrome/browser/android/preferences/website_preference_bridge.cc
@@ -91,8 +91,11 @@ static void GetOrigins(JNIEnv* env,
jembedder = ConvertUTF8ToJavaString(env, embedder);
switch (content_type) {
case CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC:
+ Java_WebsitePreferenceBridge_insertMicrophoneInfoIntoList(
+ env, list, jorigin.obj(), jembedder.obj());
+ break;
case CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA:
- Java_WebsitePreferenceBridge_insertVoiceAndVideoCaptureInfoIntoList(
+ Java_WebsitePreferenceBridge_insertCameraInfoIntoList(
env, list, jorigin.obj(), jembedder.obj());
break;
case CONTENT_SETTINGS_TYPE_GEOLOCATION:
@@ -277,33 +280,39 @@ static void SetPushNotificationSettingForOrigin(JNIEnv* env, jclass clazz,
CONTENT_SETTINGS_TYPE_NOTIFICATIONS, setting);
}
-static void GetVoiceAndVideoCaptureOrigins(JNIEnv* env,
- jclass clazz,
- jobject list,
- jboolean managedOnly) {
- GetOrigins(env, CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC, list, managedOnly);
+static void GetCameraOrigins(JNIEnv* env,
+ jclass clazz,
+ jobject list,
+ jboolean managedOnly) {
GetOrigins(env, CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA, list, managedOnly);
}
-static jint GetVoiceCaptureSettingForOrigin(JNIEnv* env, jclass clazz,
+static void GetMicrophoneOrigins(JNIEnv* env,
+ jclass clazz,
+ jobject list,
+ jboolean managedOnly) {
+ GetOrigins(env, CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC, list, managedOnly);
+}
+
+static jint GetMicrophoneSettingForOrigin(JNIEnv* env, jclass clazz,
jstring origin, jstring embedder) {
return GetSettingForOrigin(env, CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC,
origin, embedder);
}
-static jint GetVideoCaptureSettingForOrigin(JNIEnv* env, jclass clazz,
+static jint GetCameraSettingForOrigin(JNIEnv* env, jclass clazz,
jstring origin, jstring embedder) {
return GetSettingForOrigin(env, CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA,
origin, embedder);
}
-static void SetVoiceCaptureSettingForOrigin(JNIEnv* env, jclass clazz,
+static void SetMicrophoneSettingForOrigin(JNIEnv* env, jclass clazz,
jstring origin, jstring embedder, jint value) {
SetSettingForOrigin(env, CONTENT_SETTINGS_TYPE_MEDIASTREAM_MIC,
origin, ContentSettingsPattern::Wildcard(), value);
}
-static void SetVideoCaptureSettingForOrigin(JNIEnv* env, jclass clazz,
+static void SetCameraSettingForOrigin(JNIEnv* env, jclass clazz,
jstring origin, jstring embedder, jint value) {
SetSettingForOrigin(env, CONTENT_SETTINGS_TYPE_MEDIASTREAM_CAMERA,
origin, ContentSettingsPattern::Wildcard(), value);
« no previous file with comments | « chrome/browser/android/preferences/pref_service_bridge.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698