Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Unified Diff: Source/core/html/HTMLCanvasElement.cpp

Issue 1084313004: Oilpan: keep ImageData on the heap by default. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/HTMLCanvasElement.h ('k') | Source/core/html/ImageData.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLCanvasElement.cpp
diff --git a/Source/core/html/HTMLCanvasElement.cpp b/Source/core/html/HTMLCanvasElement.cpp
index 493993eca4b00d1e8096751cba398776fcd077a3..9505cdd9c9efb34c18ce1a80798f3022002dab03 100644
--- a/Source/core/html/HTMLCanvasElement.cpp
+++ b/Source/core/html/HTMLCanvasElement.cpp
@@ -484,14 +484,13 @@ String HTMLCanvasElement::toDataURLInternal(const String& mimeType, const double
String encodingMimeType = toEncodingMimeType(mimeType);
if (!m_context) {
- RefPtrWillBeRawPtr<ImageData> imageData = ImageData::create(m_size);
+ ImageData* imageData = ImageData::create(m_size);
Justin Novosad 2015/05/06 20:14:03 In this case the image data is just a temporary lo
return ImageDataBuffer(imageData->size(), imageData->data()->data()).toDataURL(encodingMimeType, quality);
}
if (m_context->is3d()) {
// Get non-premultiplied data because of inaccurate premultiplied alpha conversion of buffer()->toDataURL().
- RefPtrWillBeRawPtr<ImageData> imageData =
- toWebGLRenderingContextBase(m_context.get())->paintRenderingResultsToImageData(sourceBuffer);
+ ImageData* imageData = toWebGLRenderingContextBase(m_context.get())->paintRenderingResultsToImageData(sourceBuffer);
Justin Novosad 2015/05/06 20:14:03 same here
if (imageData)
return ImageDataBuffer(imageData->size(), imageData->data()->data()).toDataURL(encodingMimeType, quality);
m_context->paintRenderingResultsToCanvas(sourceBuffer);
« no previous file with comments | « Source/core/html/HTMLCanvasElement.h ('k') | Source/core/html/ImageData.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698